Re: [Update][PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-08-01 Thread Igor Gnatenko
On Wed, 2013-07-31 at 02:01 +0200, Rafael J. Wysocki wrote: On Thursday, July 18, 2013 02:16:09 AM Rafael J. Wysocki wrote: On Sunday, June 09, 2013 07:01:36 PM Matthew Garrett wrote: Windows 8 introduced new policy for backlight control by pushing it out to graphics drivers. This appears

Re: [Update][PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-08-01 Thread Aaron Lu
On 07/31/2013 08:01 AM, Rafael J. Wysocki wrote: On Thursday, July 18, 2013 02:16:09 AM Rafael J. Wysocki wrote: On Sunday, June 09, 2013 07:01:36 PM Matthew Garrett wrote: Windows 8 introduced new policy for backlight control by pushing it out to graphics drivers. This appears to have

[Update][PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-07-31 Thread Aaron Lu
On 07/31/2013 08:01 AM, Rafael J. Wysocki wrote: > On Thursday, July 18, 2013 02:16:09 AM Rafael J. Wysocki wrote: >> On Sunday, June 09, 2013 07:01:36 PM Matthew Garrett wrote: >>> Windows 8 introduced new policy for backlight control by pushing it out to >>> graphics drivers. This appears to

[Update][PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-07-31 Thread Igor Gnatenko
On Wed, 2013-07-31 at 02:01 +0200, Rafael J. Wysocki wrote: > On Thursday, July 18, 2013 02:16:09 AM Rafael J. Wysocki wrote: > > On Sunday, June 09, 2013 07:01:36 PM Matthew Garrett wrote: > > > Windows 8 introduced new policy for backlight control by pushing it out to > > > graphics drivers.

[Update][PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-07-31 Thread Rafael J. Wysocki
On Thursday, July 18, 2013 02:16:09 AM Rafael J. Wysocki wrote: > On Sunday, June 09, 2013 07:01:36 PM Matthew Garrett wrote: > > Windows 8 introduced new policy for backlight control by pushing it out to > > graphics drivers. This appears to have coincided with a range of vendors > > adding

[Update][PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-07-31 Thread Matthew Garrett
On Wed, 2013-07-31 at 02:01 +0200, Rafael J. Wysocki wrote: > (3) Fix i915 backlight control issues for all systems known to have them > (that may take a while) and flip the defailt for that option to set when > we > think we're ready. Unfortunately I don't have any systems that

Re: [Update][PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-07-30 Thread Rafael J. Wysocki
On Thursday, July 18, 2013 02:16:09 AM Rafael J. Wysocki wrote: On Sunday, June 09, 2013 07:01:36 PM Matthew Garrett wrote: Windows 8 introduced new policy for backlight control by pushing it out to graphics drivers. This appears to have coincided with a range of vendors adding Windows 8

Re: [Update][PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-07-30 Thread Matthew Garrett
On Wed, 2013-07-31 at 02:01 +0200, Rafael J. Wysocki wrote: (3) Fix i915 backlight control issues for all systems known to have them (that may take a while) and flip the defailt for that option to set when we think we're ready. Unfortunately I don't have any systems that reproduce

[Update][PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-07-20 Thread Felipe Contreras
On Wed, Jul 17, 2013 at 7:16 PM, Rafael J. Wysocki wrote: > On Sunday, June 09, 2013 07:01:36 PM Matthew Garrett wrote: >> Windows 8 introduced new policy for backlight control by pushing it out to >> graphics drivers. This appears to have coincided with a range of vendors >> adding Windows 8

Re: [Update][PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-07-20 Thread Felipe Contreras
On Wed, Jul 17, 2013 at 7:16 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Sunday, June 09, 2013 07:01:36 PM Matthew Garrett wrote: Windows 8 introduced new policy for backlight control by pushing it out to graphics drivers. This appears to have coincided with a range of vendors adding Windows

[Update][PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-07-18 Thread Rafael J. Wysocki
On Sunday, June 09, 2013 07:01:36 PM Matthew Garrett wrote: > Windows 8 introduced new policy for backlight control by pushing it out to > graphics drivers. This appears to have coincided with a range of vendors > adding Windows 8 checks to their backlight control code which trigger either >

[PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-07-17 Thread Yves-Alexis Perez
On mer., 2013-07-17 at 10:51 -0500, Felipe Contreras wrote: > On Sat, Jun 22, 2013 at 4:46 PM, Yves-Alexis Perez > wrote: > > Before Linux support for acpi_osi("Windows 2012") (and when booting with > > acpi_osi="!Windows 2012"), brightness keys were handled by the kernel > > just fine, whether

[PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-07-17 Thread Felipe Contreras
On Sat, Jun 22, 2013 at 4:46 PM, Yves-Alexis Perez wrote: > On dim., 2013-06-09 at 19:01 -0400, Matthew Garrett wrote: >> The first two patches in this series are picked from other patchesets aimed >> at >> solving similar problems. The last simply unregisters ACPI backlight control >> on

Re: [PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-07-17 Thread Felipe Contreras
On Sat, Jun 22, 2013 at 4:46 PM, Yves-Alexis Perez cor...@debian.org wrote: On dim., 2013-06-09 at 19:01 -0400, Matthew Garrett wrote: The first two patches in this series are picked from other patchesets aimed at solving similar problems. The last simply unregisters ACPI backlight control

[Update][PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-07-17 Thread Rafael J. Wysocki
On Sunday, June 09, 2013 07:01:36 PM Matthew Garrett wrote: Windows 8 introduced new policy for backlight control by pushing it out to graphics drivers. This appears to have coincided with a range of vendors adding Windows 8 checks to their backlight control code which trigger either awkward

Re: [PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-07-17 Thread Yves-Alexis Perez
On mer., 2013-07-17 at 10:51 -0500, Felipe Contreras wrote: On Sat, Jun 22, 2013 at 4:46 PM, Yves-Alexis Perez cor...@debian.org wrote: Before Linux support for acpi_osi(Windows 2012) (and when booting with acpi_osi=!Windows 2012), brightness keys were handled by the kernel just fine,

[PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-26 Thread Yves-Alexis Perez
On mar., 2013-06-25 at 22:33 +0100, Matthew Garrett wrote: > > I was referring to ?standardize the behaviour by leaving up to > > userspace?. A lot of thinkpads (for example) (all the pre-windows 8 > > ones) have a perfectly working ACPI backlight interface. > > And this patchset won't alter

[PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-26 Thread Yves-Alexis Perez
On mar., 2013-06-25 at 22:14 +0100, Matthew Garrett wrote: > On Tue, Jun 25, 2013 at 11:10:11PM +0200, Yves-Alexis Perez wrote: > > On mar., 2013-06-25 at 21:54 +0100, Matthew Garrett wrote: > > > I agree, we should standardise the behaviour. And the only way we can > > > standardise the

[PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-26 Thread Yves-Alexis Perez
On mar., 2013-06-25 at 21:54 +0100, Matthew Garrett wrote: > On Tue, Jun 25, 2013 at 10:43:57PM +0200, Yves-Alexis Perez wrote: > > On mar., 2013-06-25 at 17:08 +0100, Matthew Garrett wrote: > > > Right, the kernel has special-casing to hook the backlight keys up to > > > the ACPI backlight

Re: [PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-26 Thread Yves-Alexis Perez
On mar., 2013-06-25 at 17:08 +0100, Matthew Garrett wrote: On Sat, Jun 22, 2013 at 11:46:39PM +0200, Yves-Alexis Perez wrote: Before Linux support for acpi_osi(Windows 2012) (and when booting with acpi_osi=!Windows 2012), brightness keys were handled by the kernel just fine, whether in

Re: [PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-26 Thread Yves-Alexis Perez
On mar., 2013-06-25 at 21:54 +0100, Matthew Garrett wrote: On Tue, Jun 25, 2013 at 10:43:57PM +0200, Yves-Alexis Perez wrote: On mar., 2013-06-25 at 17:08 +0100, Matthew Garrett wrote: Right, the kernel has special-casing to hook the backlight keys up to the ACPI backlight control. This

Re: [PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-26 Thread Yves-Alexis Perez
On mar., 2013-06-25 at 22:14 +0100, Matthew Garrett wrote: On Tue, Jun 25, 2013 at 11:10:11PM +0200, Yves-Alexis Perez wrote: On mar., 2013-06-25 at 21:54 +0100, Matthew Garrett wrote: I agree, we should standardise the behaviour. And the only way we can standardise the behaviour is to

Re: [PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-26 Thread Yves-Alexis Perez
On mar., 2013-06-25 at 22:33 +0100, Matthew Garrett wrote: I was referring to “standardize the behaviour by leaving up to userspace”. A lot of thinkpads (for example) (all the pre-windows 8 ones) have a perfectly working ACPI backlight interface. And this patchset won't alter their

[PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-25 Thread Matthew Garrett
On Tue, Jun 25, 2013 at 11:46:01PM +0200, Yves-Alexis Perez wrote: > But if that introduce regressions, shouldn't workarounds be found then? > Sorry if I keep repeating that but brightness keys handling in-kernel is > quite a useful feature and losing it (because of the ?behave exactly > like

[PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-25 Thread Yves-Alexis Perez
On mar., 2013-06-25 at 17:08 +0100, Matthew Garrett wrote: > On Sat, Jun 22, 2013 at 11:46:39PM +0200, Yves-Alexis Perez wrote: > > > Before Linux support for acpi_osi("Windows 2012") (and when booting with > > acpi_osi="!Windows 2012"), brightness keys were handled by the kernel > > just fine,

[PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-25 Thread Matthew Garrett
On Tue, Jun 25, 2013 at 11:30:37PM +0200, Yves-Alexis Perez wrote: > On mar., 2013-06-25 at 22:14 +0100, Matthew Garrett wrote: > > Which, as we've already established, you don't - Lenovo broke it. Your > > Thinkpad claims to have 100 available levels, and most of them don't > > work. The kernel

[PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-25 Thread Matthew Garrett
On Tue, Jun 25, 2013 at 11:10:11PM +0200, Yves-Alexis Perez wrote: > On mar., 2013-06-25 at 21:54 +0100, Matthew Garrett wrote: > > I agree, we should standardise the behaviour. And the only way we can > > standardise the behaviour is to leave it up to userspace. > > > It's pretty clear we

[PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-25 Thread Matthew Garrett
On Tue, Jun 25, 2013 at 10:43:57PM +0200, Yves-Alexis Perez wrote: > On mar., 2013-06-25 at 17:08 +0100, Matthew Garrett wrote: > > Right, the kernel has special-casing to hook the backlight keys up to > > the ACPI backlight control. This is an awful thing, because there's no > > way to detect

[PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-25 Thread Daniel Vetter
On Tue, Jun 25, 2013 at 6:08 PM, Matthew Garrett wrote: > On Sat, Jun 22, 2013 at 11:46:39PM +0200, Yves-Alexis Perez wrote: > >> Before Linux support for acpi_osi("Windows 2012") (and when booting with >> acpi_osi="!Windows 2012"), brightness keys were handled by the kernel >> just fine, whether

[PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-25 Thread Matthew Garrett
On Tue, Jun 25, 2013 at 06:10:35PM +0200, Daniel Vetter wrote: > Do we have any chances to amend this mistake by (gradually) phasing > out support for the direct keypress forwarding in ACPI? Or at least > some plans? We could make the default value of brightness_switch_enabled a config variable

[PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-25 Thread Matthew Garrett
On Sat, Jun 22, 2013 at 11:46:39PM +0200, Yves-Alexis Perez wrote: > Before Linux support for acpi_osi("Windows 2012") (and when booting with > acpi_osi="!Windows 2012"), brightness keys were handled by the kernel > just fine, whether in console, in the display manager or in my desktop >

Re: [PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-25 Thread Matthew Garrett
On Sat, Jun 22, 2013 at 11:46:39PM +0200, Yves-Alexis Perez wrote: Before Linux support for acpi_osi(Windows 2012) (and when booting with acpi_osi=!Windows 2012), brightness keys were handled by the kernel just fine, whether in console, in the display manager or in my desktop environment

Re: [PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-25 Thread Daniel Vetter
On Tue, Jun 25, 2013 at 6:08 PM, Matthew Garrett mj...@srcf.ucam.org wrote: On Sat, Jun 22, 2013 at 11:46:39PM +0200, Yves-Alexis Perez wrote: Before Linux support for acpi_osi(Windows 2012) (and when booting with acpi_osi=!Windows 2012), brightness keys were handled by the kernel just fine,

Re: [PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-25 Thread Matthew Garrett
On Tue, Jun 25, 2013 at 06:10:35PM +0200, Daniel Vetter wrote: Do we have any chances to amend this mistake by (gradually) phasing out support for the direct keypress forwarding in ACPI? Or at least some plans? We could make the default value of brightness_switch_enabled a config variable

Re: [PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-25 Thread Matthew Garrett
On Tue, Jun 25, 2013 at 10:43:57PM +0200, Yves-Alexis Perez wrote: On mar., 2013-06-25 at 17:08 +0100, Matthew Garrett wrote: Right, the kernel has special-casing to hook the backlight keys up to the ACPI backlight control. This is an awful thing, because there's no way to detect this

Re: [PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-25 Thread Matthew Garrett
On Tue, Jun 25, 2013 at 11:10:11PM +0200, Yves-Alexis Perez wrote: On mar., 2013-06-25 at 21:54 +0100, Matthew Garrett wrote: I agree, we should standardise the behaviour. And the only way we can standardise the behaviour is to leave it up to userspace. It's pretty clear we disagree on

Re: [PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-25 Thread Matthew Garrett
On Tue, Jun 25, 2013 at 11:30:37PM +0200, Yves-Alexis Perez wrote: On mar., 2013-06-25 at 22:14 +0100, Matthew Garrett wrote: Which, as we've already established, you don't - Lenovo broke it. Your Thinkpad claims to have 100 available levels, and most of them don't work. The kernel has no

Re: [PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-25 Thread Matthew Garrett
On Tue, Jun 25, 2013 at 11:46:01PM +0200, Yves-Alexis Perez wrote: But if that introduce regressions, shouldn't workarounds be found then? Sorry if I keep repeating that but brightness keys handling in-kernel is quite a useful feature and losing it (because of the “behave exactly like Windows

[PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-23 Thread Yves-Alexis Perez
On dim., 2013-06-09 at 19:01 -0400, Matthew Garrett wrote: > The first two patches in this series are picked from other patchesets aimed at > solving similar problems. The last simply unregisters ACPI backlight control > on Windows 8 systems when using an Intel GPU. Similar code could be added to

Re: [PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-23 Thread Yves-Alexis Perez
On dim., 2013-06-09 at 19:01 -0400, Matthew Garrett wrote: The first two patches in this series are picked from other patchesets aimed at solving similar problems. The last simply unregisters ACPI backlight control on Windows 8 systems when using an Intel GPU. Similar code could be added to

[PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-11 Thread Seth Forshee
On Sun, Jun 09, 2013 at 07:01:36PM -0400, Matthew Garrett wrote: > Windows 8 introduced new policy for backlight control by pushing it out to > graphics drivers. This appears to have coincided with a range of vendors > adding Windows 8 checks to their backlight control code which trigger either >

Re: [PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-11 Thread Seth Forshee
On Sun, Jun 09, 2013 at 07:01:36PM -0400, Matthew Garrett wrote: Windows 8 introduced new policy for backlight control by pushing it out to graphics drivers. This appears to have coincided with a range of vendors adding Windows 8 checks to their backlight control code which trigger either

[PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-10 Thread Rafael J. Wysocki
Hi Matthew, On Sunday, June 09, 2013 07:01:36 PM Matthew Garrett wrote: > Windows 8 introduced new policy for backlight control by pushing it out to > graphics drivers. This appears to have coincided with a range of vendors > adding Windows 8 checks to their backlight control code which trigger

[PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-10 Thread Matthew Garrett
On Mon, 2013-06-10 at 13:59 +0200, Rafael J. Wysocki wrote: > I happen to know that alternative solution to this problem is being worked on, > so I'm going to wait until it is submitted and then we'll decide what to > merge. Sure. > I'm slightly concerned about unregistering ACPI backlight

Re: [PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-10 Thread Rafael J. Wysocki
Hi Matthew, On Sunday, June 09, 2013 07:01:36 PM Matthew Garrett wrote: Windows 8 introduced new policy for backlight control by pushing it out to graphics drivers. This appears to have coincided with a range of vendors adding Windows 8 checks to their backlight control code which trigger

Re: [PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-10 Thread Matthew Garrett
On Mon, 2013-06-10 at 13:59 +0200, Rafael J. Wysocki wrote: I happen to know that alternative solution to this problem is being worked on, so I'm going to wait until it is submitted and then we'll decide what to merge. Sure. I'm slightly concerned about unregistering ACPI backlight control

[PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-09 Thread Matthew Garrett
Windows 8 introduced new policy for backlight control by pushing it out to graphics drivers. This appears to have coincided with a range of vendors adding Windows 8 checks to their backlight control code which trigger either awkward behaviour (Lenovo) or complete brokenness (some Dells). The

[PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-09 Thread Matthew Garrett
Windows 8 introduced new policy for backlight control by pushing it out to graphics drivers. This appears to have coincided with a range of vendors adding Windows 8 checks to their backlight control code which trigger either awkward behaviour (Lenovo) or complete brokenness (some Dells). The