Re: [PATCH 0/3] omapdrm: Fix runtime PM issues at module load and unload time

2018-11-06 Thread Tony Lindgren
* Laurent Pinchart [181105 15:14]: > Hi Tony, > > On Thursday, 1 November 2018 18:17:43 EET Laurent Pinchart wrote: > > On Thursday, 1 November 2018 17:58:56 EET Tony Lindgren wrote: > > > * Laurent Pinchart [181101 12:13]: > > >> On Thursday, 1 November 2018 13:47:40 EET Tomi Valkeinen wrote:

Re: [PATCH 0/3] omapdrm: Fix runtime PM issues at module load and unload time

2018-11-05 Thread Laurent Pinchart
Hi Tony, On Thursday, 1 November 2018 18:17:43 EET Laurent Pinchart wrote: > On Thursday, 1 November 2018 17:58:56 EET Tony Lindgren wrote: > > * Laurent Pinchart [181101 12:13]: > >> On Thursday, 1 November 2018 13:47:40 EET Tomi Valkeinen wrote: > >>> We do dispc_runtime_get/put in the HDMI

Re: [PATCH 0/3] omapdrm: Fix runtime PM issues at module load and unload time

2018-11-02 Thread Tony Lindgren
Hi, * Laurent Pinchart [181101 12:13]: > On Thursday, 1 November 2018 13:47:40 EET Tomi Valkeinen wrote: > > We do dispc_runtime_get/put in the HDMI driver's suspend/resume too, so > > don't we need similar hack (as you add in dsi.c) there also? > > We would if we had to access HDMI registers

Re: [PATCH 0/3] omapdrm: Fix runtime PM issues at module load and unload time

2018-11-01 Thread Laurent Pinchart
Hi Tony, On Thursday, 1 November 2018 17:58:56 EET Tony Lindgren wrote: > * Laurent Pinchart [181101 12:13]: > > On Thursday, 1 November 2018 13:47:40 EET Tomi Valkeinen wrote: > > > We do dispc_runtime_get/put in the HDMI driver's suspend/resume too, so > > > don't we need similar hack (as you

Re: [PATCH 0/3] omapdrm: Fix runtime PM issues at module load and unload time

2018-11-01 Thread Tomi Valkeinen
On 01/11/18 14:13, Laurent Pinchart wrote: >> Thanks for debugging this! I have to say I really don't like these >> (well, 2 is fine), as they feel like hacks. > > I assume you also have nothing against the first hunk of patch 3/3. Yes. And after our discussion, I think 1 is fine too, so the

Re: [PATCH 0/3] omapdrm: Fix runtime PM issues at module load and unload time

2018-11-01 Thread Laurent Pinchart
Ho Tomi, On Thursday, 1 November 2018 13:47:40 EET Tomi Valkeinen wrote: > On 01/11/18 12:25, Laurent Pinchart wrote: > > Hello, > > > > This series fixes crashes in the omapdss driver at both load and unload > > time, due to runtime PM problems related to probe deferral. The bugs got > >

Re: [PATCH 0/3] omapdrm: Fix runtime PM issues at module load and unload time

2018-11-01 Thread Tomi Valkeinen
Hi Laurent, On 01/11/18 12:25, Laurent Pinchart wrote: > Hello, > > This series fixes crashes in the omapdss driver at both load and unload > time, due to runtime PM problems related to probe deferral. The bugs got > introduced in v4.20-rc, this should thus be considered as v4.20 fixes. > > At

[PATCH 0/3] omapdrm: Fix runtime PM issues at module load and unload time

2018-11-01 Thread Laurent Pinchart
Hello, This series fixes crashes in the omapdss driver at both load and unload time, due to runtime PM problems related to probe deferral. The bugs got introduced in v4.20-rc, this should thus be considered as v4.20 fixes. At the core of the problem comes commit 27d624527d99 ("drm/omap: dss: