Re: [PATCH 00/10] drm/vkms: rework crc worker

2019-06-30 Thread Rodrigo Siqueira
On 06/26, Daniel Vetter wrote: > On Wed, Jun 26, 2019 at 3:44 AM Rodrigo Siqueira > wrote: > > > > On 06/19, Daniel Vetter wrote: > > > On Tue, Jun 18, 2019 at 11:54 PM Rodrigo Siqueira > > > wrote: > > > > > > > > On Tue, Jun 18, 2019 at 5:56 AM Daniel Vetter wrote: > > > > > > > > > > On Mon,

Re: [PATCH 00/10] drm/vkms: rework crc worker

2019-06-26 Thread Rodrigo Siqueira
On Wed, Jun 26, 2019 at 4:55 AM Daniel Vetter wrote: > > On Wed, Jun 26, 2019 at 3:44 AM Rodrigo Siqueira > wrote: > > > > On 06/19, Daniel Vetter wrote: > > > On Tue, Jun 18, 2019 at 11:54 PM Rodrigo Siqueira > > > wrote: > > > > > > > > On Tue, Jun 18, 2019 at 5:56 AM Daniel Vetter wrote: >

Re: [PATCH 00/10] drm/vkms: rework crc worker

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 3:44 AM Rodrigo Siqueira wrote: > > On 06/19, Daniel Vetter wrote: > > On Tue, Jun 18, 2019 at 11:54 PM Rodrigo Siqueira > > wrote: > > > > > > On Tue, Jun 18, 2019 at 5:56 AM Daniel Vetter wrote: > > > > > > > > On Mon, Jun 17, 2019 at 11:49:04PM -0300, Rodrigo Siqueira

Re: [PATCH 00/10] drm/vkms: rework crc worker

2019-06-25 Thread Rodrigo Siqueira
On 06/19, Daniel Vetter wrote: > On Tue, Jun 18, 2019 at 11:54 PM Rodrigo Siqueira > wrote: > > > > On Tue, Jun 18, 2019 at 5:56 AM Daniel Vetter wrote: > > > > > > On Mon, Jun 17, 2019 at 11:49:04PM -0300, Rodrigo Siqueira wrote: > > > > On 06/12, Daniel Vetter wrote: > > > > > On Wed, Jun 12,

Re: [PATCH 00/10] drm/vkms: rework crc worker

2019-06-18 Thread Daniel Vetter
On Wed, Jun 19, 2019 at 12:25 AM Rodrigo Siqueira wrote: > > On Tue, Jun 18, 2019 at 7:08 PM Daniel Vetter wrote: > > > > On Wed, Jun 19, 2019 at 12:06 AM Daniel Vetter wrote: > > > > > > On Tue, Jun 18, 2019 at 11:54 PM Rodrigo Siqueira > > > wrote: > > > > Finally, not related with this

Re: [PATCH 00/10] drm/vkms: rework crc worker

2019-06-18 Thread Rodrigo Siqueira
On Tue, Jun 18, 2019 at 7:08 PM Daniel Vetter wrote: > > On Wed, Jun 19, 2019 at 12:06 AM Daniel Vetter wrote: > > > > On Tue, Jun 18, 2019 at 11:54 PM Rodrigo Siqueira > > wrote: > > > > > > On Tue, Jun 18, 2019 at 5:56 AM Daniel Vetter wrote: > > > > > > > > On Mon, Jun 17, 2019 at

Re: [PATCH 00/10] drm/vkms: rework crc worker

2019-06-18 Thread Daniel Vetter
On Wed, Jun 19, 2019 at 12:06 AM Daniel Vetter wrote: > > On Tue, Jun 18, 2019 at 11:54 PM Rodrigo Siqueira > wrote: > > > > On Tue, Jun 18, 2019 at 5:56 AM Daniel Vetter wrote: > > > > > > On Mon, Jun 17, 2019 at 11:49:04PM -0300, Rodrigo Siqueira wrote: > > > > On 06/12, Daniel Vetter wrote:

Re: [PATCH 00/10] drm/vkms: rework crc worker

2019-06-18 Thread Daniel Vetter
On Tue, Jun 18, 2019 at 11:54 PM Rodrigo Siqueira wrote: > > On Tue, Jun 18, 2019 at 5:56 AM Daniel Vetter wrote: > > > > On Mon, Jun 17, 2019 at 11:49:04PM -0300, Rodrigo Siqueira wrote: > > > On 06/12, Daniel Vetter wrote: > > > > On Wed, Jun 12, 2019 at 10:28:41AM -0300, Rodrigo Siqueira

Re: [PATCH 00/10] drm/vkms: rework crc worker

2019-06-18 Thread Rodrigo Siqueira
On Tue, Jun 18, 2019 at 5:56 AM Daniel Vetter wrote: > > On Mon, Jun 17, 2019 at 11:49:04PM -0300, Rodrigo Siqueira wrote: > > On 06/12, Daniel Vetter wrote: > > > On Wed, Jun 12, 2019 at 10:28:41AM -0300, Rodrigo Siqueira wrote: > > > > Hi Daniel, > > > > > > > > First of all, thank you very

Re: [PATCH 00/10] drm/vkms: rework crc worker

2019-06-18 Thread Daniel Vetter
On Mon, Jun 17, 2019 at 11:49:04PM -0300, Rodrigo Siqueira wrote: > On 06/12, Daniel Vetter wrote: > > On Wed, Jun 12, 2019 at 10:28:41AM -0300, Rodrigo Siqueira wrote: > > > Hi Daniel, > > > > > > First of all, thank you very much for your patchset. > > > > > > I tried to make a detailed review

Re: [PATCH 00/10] drm/vkms: rework crc worker

2019-06-17 Thread Rodrigo Siqueira
On 06/12, Daniel Vetter wrote: > On Wed, Jun 12, 2019 at 10:28:41AM -0300, Rodrigo Siqueira wrote: > > Hi Daniel, > > > > First of all, thank you very much for your patchset. > > > > I tried to make a detailed review of your series, and you can see my > > comments in each patch. You’ll notice

Re: [PATCH 00/10] drm/vkms: rework crc worker

2019-06-12 Thread Daniel Vetter
On Wed, Jun 12, 2019 at 10:28:41AM -0300, Rodrigo Siqueira wrote: > Hi Daniel, > > First of all, thank you very much for your patchset. > > I tried to make a detailed review of your series, and you can see my > comments in each patch. You’ll notice that I asked many things related > to the DRM

Re: [PATCH 00/10] drm/vkms: rework crc worker

2019-06-12 Thread Rodrigo Siqueira
Hi Daniel, First of all, thank you very much for your patchset. I tried to make a detailed review of your series, and you can see my comments in each patch. You’ll notice that I asked many things related to the DRM subsystem with the hope that I could learn a little bit more about DRM from your

[PATCH 00/10] drm/vkms: rework crc worker

2019-06-06 Thread Daniel Vetter
Hi all, This here is the first part of a rework for the vkms crc worker. I think this should fix all the locking/races/use-after-free issues I spotted in the code. There's more work we can do in the future as a follow-up: - directly access vkms_plane_state->base in the crc worker, with this