Re: [PATCH 01/21] drm/cma-helper: Rework DRM_GEM_CMA_VMAP_DRIVER_OPS macro

2020-05-25 Thread Thomas Zimmermann
Hi Sam Am 22.05.20 um 19:48 schrieb Sam Ravnborg: > Hi Thomas. > > On Fri, May 22, 2020 at 03:52:26PM +0200, Thomas Zimmermann wrote: >> Rename the macro to DRM_GEM_CMA_DRIVER_OPS to align with SHMEM >> helpers. > This part is fine, I like that the naming is somehow consistent. > >> An internal

Re: [PATCH 01/21] drm/cma-helper: Rework DRM_GEM_CMA_VMAP_DRIVER_OPS macro

2020-05-22 Thread Laurent Pinchart
Hello, On Fri, May 22, 2020 at 07:48:35PM +0200, Sam Ravnborg wrote: > On Fri, May 22, 2020 at 03:52:26PM +0200, Thomas Zimmermann wrote: > > Rename the macro to DRM_GEM_CMA_DRIVER_OPS to align with SHMEM > > helpers. > > This part is fine, I like that the naming is somehow consistent. > > > An

Re: [PATCH 01/21] drm/cma-helper: Rework DRM_GEM_CMA_VMAP_DRIVER_OPS macro

2020-05-22 Thread Sam Ravnborg
Hi Emil. > > Please fix zte/zx_drm_drv.c which also uses DRM_GEM_CMA_VMAP_DRIVER_OPS. > > > Isn't DRM_GEM_CMA_VMAP_DRIVER_OPS introduced to zte with the last > patch in the series? You are right, I just applied all patches and throw them after my build script and zte failed. Sam

Re: [PATCH 01/21] drm/cma-helper: Rework DRM_GEM_CMA_VMAP_DRIVER_OPS macro

2020-05-22 Thread Emil Velikov
On Fri, 22 May 2020 at 18:48, Sam Ravnborg wrote: > > Hi Thomas. > > On Fri, May 22, 2020 at 03:52:26PM +0200, Thomas Zimmermann wrote: > > Rename the macro to DRM_GEM_CMA_DRIVER_OPS to align with SHMEM > > helpers. > This part is fine, I like that the naming is somehow consistent. > > > An

Re: [PATCH 01/21] drm/cma-helper: Rework DRM_GEM_CMA_VMAP_DRIVER_OPS macro

2020-05-22 Thread Sam Ravnborg
Hi Thomas. On Fri, May 22, 2020 at 03:52:26PM +0200, Thomas Zimmermann wrote: > Rename the macro to DRM_GEM_CMA_DRIVER_OPS to align with SHMEM > helpers. This part is fine, I like that the naming is somehow consistent. > An internal version is provided for drivers that override > the default

[PATCH 01/21] drm/cma-helper: Rework DRM_GEM_CMA_VMAP_DRIVER_OPS macro

2020-05-22 Thread Thomas Zimmermann
Rename the macro to DRM_GEM_CMA_DRIVER_OPS to align with SHMEM helpers. An internal version is provided for drivers that override the default .dumb_create callback. Adapt drivers to the changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_cma_helper.c | 2 +-