Re: [PATCH 01/36] drm/fourcc: Add 2 plane YCbCr 10bit format support

2019-09-25 Thread Daniel Vetter
On Tue, Sep 24, 2019 at 8:46 AM sandy.huang wrote: > > > 在 2019/9/23 下午9:06, Daniel Vetter 写道: > > On Mon, Sep 23, 2019 at 2:40 PM Sandy Huang wrote: > >> The drm_format_info.cpp[3] unit is BytePerPlane, when we add define > >> 10bit YUV format, here have some problem. > >> So we change cpp to bp

Re: [PATCH 01/36] drm/fourcc: Add 2 plane YCbCr 10bit format support

2019-09-25 Thread sandy.huang
在 2019/9/24 下午6:12, Ayan Halder 写道: On Tue, Sep 24, 2019 at 02:46:09PM +0800, sandy.huang wrote: Hi Sandy, 在 2019/9/23 下午9:06, Daniel Vetter 写道: On Mon, Sep 23, 2019 at 2:40 PM Sandy Huang wrote: The drm_format_info.cpp[3] unit is BytePerPlane, when we add define 10bit YUV format, here have

Re: [PATCH 01/36] drm/fourcc: Add 2 plane YCbCr 10bit format support

2019-09-24 Thread Ayan Halder
On Tue, Sep 24, 2019 at 02:46:09PM +0800, sandy.huang wrote: Hi Sandy, > > 在 2019/9/23 下午9:06, Daniel Vetter 写道: > >On Mon, Sep 23, 2019 at 2:40 PM Sandy Huang wrote: > >>The drm_format_info.cpp[3] unit is BytePerPlane, when we add define > >>10bit YUV format, here have some problem. > >>So we c

Re: [PATCH 01/36] drm/fourcc: Add 2 plane YCbCr 10bit format support

2019-09-24 Thread sandy.huang
在 2019/9/24 下午2:46, sandy.huang 写道: 在 2019/9/23 下午9:06, Daniel Vetter 写道: On Mon, Sep 23, 2019 at 2:40 PM Sandy Huang wrote: The drm_format_info.cpp[3] unit is BytePerPlane, when we add define 10bit YUV format, here have some problem. So we change cpp to bpp, use unit BitPerPlane to describe

Re: [PATCH 01/36] drm/fourcc: Add 2 plane YCbCr 10bit format support

2019-09-23 Thread sandy.huang
在 2019/9/24 上午2:30, Ville Syrjälä 写道: On Mon, Sep 23, 2019 at 06:05:22AM -0700, sandy.huang wrote: 在 2019/9/23 上午5:53, Ville Syrjälä 写道: On Mon, Sep 23, 2019 at 08:38:50PM +0800, Sandy Huang wrote: diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h index 3feeaa3..5fe8

Re: [PATCH 01/36] drm/fourcc: Add 2 plane YCbCr 10bit format support

2019-09-23 Thread sandy.huang
在 2019/9/23 下午9:06, Daniel Vetter 写道: On Mon, Sep 23, 2019 at 2:40 PM Sandy Huang wrote: The drm_format_info.cpp[3] unit is BytePerPlane, when we add define 10bit YUV format, here have some problem. So we change cpp to bpp, use unit BitPerPlane to describe the data format. Signed-off-by: San

Re: [PATCH 01/36] drm/fourcc: Add 2 plane YCbCr 10bit format support

2019-09-23 Thread Ville Syrjälä
On Mon, Sep 23, 2019 at 06:05:22AM -0700, sandy.huang wrote: > > 在 2019/9/23 上午5:53, Ville Syrjälä 写道: > > On Mon, Sep 23, 2019 at 08:38:50PM +0800, Sandy Huang wrote: > >> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > >> index 3feeaa3..5fe89e9 100644 > >> --- a/incl

Re: [PATCH 01/36] drm/fourcc: Add 2 plane YCbCr 10bit format support

2019-09-23 Thread Daniel Vetter
On Mon, Sep 23, 2019 at 2:40 PM Sandy Huang wrote: > > The drm_format_info.cpp[3] unit is BytePerPlane, when we add define > 10bit YUV format, here have some problem. > So we change cpp to bpp, use unit BitPerPlane to describe the data > format. > > Signed-off-by: Sandy Huang Whatever the layout

Re: [PATCH 01/36] drm/fourcc: Add 2 plane YCbCr 10bit format support

2019-09-23 Thread sandy.huang
在 2019/9/23 上午5:53, Ville Syrjälä 写道: On Mon, Sep 23, 2019 at 08:38:50PM +0800, Sandy Huang wrote: diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h index 3feeaa3..5fe89e9 100644 --- a/include/uapi/drm/drm_fourcc.h +++ b/include/uapi/drm/drm_fourcc.h @@ -266,6 +266,21 @

Re: [PATCH 01/36] drm/fourcc: Add 2 plane YCbCr 10bit format support

2019-09-23 Thread Ville Syrjälä
On Mon, Sep 23, 2019 at 08:38:50PM +0800, Sandy Huang wrote: > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > index 3feeaa3..5fe89e9 100644 > --- a/include/uapi/drm/drm_fourcc.h > +++ b/include/uapi/drm/drm_fourcc.h > @@ -266,6 +266,21 @@ extern "C" { > #define DRM_FO

[PATCH 01/36] drm/fourcc: Add 2 plane YCbCr 10bit format support

2019-09-23 Thread Sandy Huang
The drm_format_info.cpp[3] unit is BytePerPlane, when we add define 10bit YUV format, here have some problem. So we change cpp to bpp, use unit BitPerPlane to describe the data format. Signed-off-by: Sandy Huang --- drivers/gpu/drm/drm_client.c| 4 +- drivers/gpu/drm/drm_fb_helper.c