Re: [PATCH 02/11] drm/i915/mst: Remove broken MST DSC support

2023-06-15 Thread Dave Airlie
On Wed, 3 May 2023 at 22:23, Lisovskiy, Stanislav wrote: > > On Wed, May 03, 2023 at 02:07:04PM +0300, Ville Syrjälä wrote: > > On Wed, May 03, 2023 at 10:36:42AM +0300, Lisovskiy, Stanislav wrote: > > > On Tue, May 02, 2023 at 05:38:57PM +0300, Ville Syrjala wrote: > > > > From: Ville Syrjälä >

Re: [PATCH 02/11] drm/i915/mst: Remove broken MST DSC support

2023-05-03 Thread Lisovskiy, Stanislav
On Wed, May 03, 2023 at 02:07:04PM +0300, Ville Syrjälä wrote: > On Wed, May 03, 2023 at 10:36:42AM +0300, Lisovskiy, Stanislav wrote: > > On Tue, May 02, 2023 at 05:38:57PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > The MST DSC code has a myriad of issues: > > > -

Re: [PATCH 02/11] drm/i915/mst: Remove broken MST DSC support

2023-05-03 Thread Ville Syrjälä
On Wed, May 03, 2023 at 10:36:42AM +0300, Lisovskiy, Stanislav wrote: > On Tue, May 02, 2023 at 05:38:57PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > The MST DSC code has a myriad of issues: > > - Platform checks are wrong (MST+DSC is TGL+ only IIRC) > > - Return values of

Re: [PATCH 02/11] drm/i915/mst: Remove broken MST DSC support

2023-05-03 Thread Lisovskiy, Stanislav
On Tue, May 02, 2023 at 05:38:57PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > The MST DSC code has a myriad of issues: > - Platform checks are wrong (MST+DSC is TGL+ only IIRC) > - Return values of .mode_valid_ctx() are wrong > - .mode_valid_ctx() assumes bigjoiner might be used, but

Re: [PATCH 02/11] drm/i915/mst: Remove broken MST DSC support

2023-05-03 Thread Lisovskiy, Stanislav
On Tue, May 02, 2023 at 05:38:57PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > The MST DSC code has a myriad of issues: > - Platform checks are wrong (MST+DSC is TGL+ only IIRC) > - Return values of .mode_valid_ctx() are wrong > - .mode_valid_ctx() assumes bigjoiner might be used, but

[PATCH 02/11] drm/i915/mst: Remove broken MST DSC support

2023-05-02 Thread Ville Syrjala
From: Ville Syrjälä The MST DSC code has a myriad of issues: - Platform checks are wrong (MST+DSC is TGL+ only IIRC) - Return values of .mode_valid_ctx() are wrong - .mode_valid_ctx() assumes bigjoiner might be used, but ther rest of the code doesn't agree - compressed bpp calculations don't