Re: [PATCH 02/12] drm/ast: Handle configuration without P2A bridge

2017-02-24 Thread Joel Stanley
On Fri, Feb 24, 2017 at 9:23 AM, Benjamin Herrenschmidt wrote: > static int ast_get_dram_info(struct drm_device *dev) > { > + struct device_node *np = dev->pdev->dev.of_node; > struct ast_private *ast = dev->dev_private; > - uint32_t data, data2; > - uint32_t denum, nu

RE: [PATCH 02/12] drm/ast: Handle configuration without P2A bridge

2017-02-23 Thread YC Chen
Tested-by: Y.C. Chen -Original Message- From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] Sent: Friday, February 24, 2017 6:54 AM To: dri-devel@lists.freedesktop.org Cc: YC Chen ; airl...@redhat.com; e...@suse.come; linuxppc-...@ozlabs.org Subject: [PATCH 02/12] drm/ast

Re: [PATCH 02/12] drm/ast: Handle configuration without P2A bridge

2017-02-23 Thread Benjamin Herrenschmidt
On Fri, 2017-02-24 at 12:51 +1030, Joel Stanley wrote: > > Are these properties supposed to repeat the prefix "ast,ast"? > > We've chosen aspeed as the vendor prefix for Aspeed stuff. Sent my reply too early ... so yes, I can change that, our FW hasn't merge the FW side yet. I'll respin now. >

Re: [PATCH 02/12] drm/ast: Handle configuration without P2A bridge

2017-02-23 Thread Benjamin Herrenschmidt
On Fri, 2017-02-24 at 12:51 +1030, Joel Stanley wrote: > Are these properties supposed to repeat the prefix "ast,ast"? > > We've chosen aspeed as the vendor prefix for Aspeed stuff. Argh no, that's a typo... must have worked in my tests bcs the defaults are fine. I'll update. Cheers, Ben. _

[PATCH 02/12] drm/ast: Handle configuration without P2A bridge

2017-02-23 Thread Benjamin Herrenschmidt
From: Russell Currey The ast driver configures a window to enable access into BMC memory space in order to read some configuration registers. If this window is disabled, which it can be from the BMC side, the ast driver can't function. Closing this window is a necessity for security if a machin