Re: [PATCH 02/23] drm/atomic-helper: Make drm_atomic_helper_disable_all() update the plane->fb pointers

2018-03-29 Thread Ville Syrjälä
On Mon, Mar 26, 2018 at 10:28:06PM +0200, Daniel Vetter wrote: > On Thu, Mar 22, 2018 at 05:22:52PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > drm_atomic_helper_shutdown() needs to release the reference held by > > plane->fb, so we want to use

Re: [PATCH 02/23] drm/atomic-helper: Make drm_atomic_helper_disable_all() update the plane->fb pointers

2018-03-26 Thread Daniel Vetter
On Thu, Mar 22, 2018 at 05:22:52PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > drm_atomic_helper_shutdown() needs to release the reference held by > plane->fb, so we want to use drm_atomic_clean_old_fb() in > drm_atomic_helper_disable_all(). However

Re: [PATCH 02/23] drm/atomic-helper: Make drm_atomic_helper_disable_all() update the plane->fb pointers

2018-03-26 Thread Daniel Vetter
On Thu, Mar 22, 2018 at 05:22:52PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > drm_atomic_helper_shutdown() needs to release the reference held by > plane->fb, so we want to use drm_atomic_clean_old_fb() in > drm_atomic_helper_disable_all(). However

[PATCH 02/23] drm/atomic-helper: Make drm_atomic_helper_disable_all() update the plane->fb pointers

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä drm_atomic_helper_shutdown() needs to release the reference held by plane->fb, so we want to use drm_atomic_clean_old_fb() in drm_atomic_helper_disable_all(). However during suspend/resume, gpu reset and load detection we should probably leave