Re: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

2023-06-06 Thread Thomas Zimmermann
Zimmermann ; John Paul Adrian Glaubitz ; linux-o...@vger.kernel.org Subject: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device Struct gpio_backlight_platform_data refers to a platform device within the Linux device hierarchy. The test in gpio_backlight_check_fb() compares

Re: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

2023-06-06 Thread Dan Carpenter
; linux- > > > s...@vger.kernel.org; linux-stag...@lists.linux.dev; dri- > > > de...@lists.freedesktop.org; Thomas Zimmermann > > > ; John Paul Adrian Glaubitz > > berlin.de>; linux-o...@vger.kernel.org > > > Subject: [PATCH 02/30] backlight/gpio_backlight: Compare against s

Re: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

2023-06-06 Thread Thomas Zimmermann
...@linaro.org; jingooh...@gmail.com Cc: linux-fb...@vger.kernel.org; Rich Felker ; linux- s...@vger.kernel.org; linux-stag...@lists.linux.dev; dri- de...@lists.freedesktop.org; Thomas Zimmermann ; John Paul Adrian Glaubitz ; linux-o...@vger.kernel.org Subject: [PATCH 02/30] backlight/gpio_backlight

RE: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

2023-06-05 Thread Ruhl, Michael J
gmail.com; linux- >fb...@vger.kernel.org; Rich Felker ; linux- >s...@vger.kernel.org; linux-stag...@lists.linux.dev; dri- >de...@lists.freedesktop.org; John Paul Adrian Glaubitz berlin.de>; linux-o...@vger.kernel.org >Subject: Re: [PATCH 02/30] backlight/gpio_backlight: Compare against

Re: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

2023-06-05 Thread Sam Ravnborg
Hi Michael. > > > >Fixes a bug in the backlight driver and prepares fbdev for making > >struct fb_info.dev optional. > > I only see a rename from fbdev to dev... > > Is there missing code? > > Would a fixes: be useful? > > M > > >@@ -35,7 +35,7 @@ static int gpio_backlight_check_fb(struct

RE: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

2023-06-05 Thread Ruhl, Michael J
ail.com >Cc: linux-fb...@vger.kernel.org; Rich Felker ; linux- >s...@vger.kernel.org; linux-stag...@lists.linux.dev; dri- >de...@lists.freedesktop.org; Thomas Zimmermann >; John Paul Adrian Glaubitz berlin.de>; linux-o...@vger.kernel.org >Subject: [PATCH 02/30] backlight

[PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

2023-06-05 Thread Thomas Zimmermann
Struct gpio_backlight_platform_data refers to a platform device within the Linux device hierarchy. The test in gpio_backlight_check_fb() compares it against the fbdev device in struct fb_info.dev, which is different. Fix the test by comparing to struct fb_info.device. Fixes a bug in the backlight