Re: [PATCH 04/10] drm/tegra: Set fbdev flags

2023-07-06 Thread Thomas Zimmermann
Hi Am 05.07.23 um 11:34 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: [...] + info->flags |= FBINFO_VIRTFB; I see that all fbdev drivers just do: info->flags = FBINFO_FLAG_DEFAULT | FBINFO_VIRTFB Guess you are doing in two assignments to be consistent with drm_fbd

Re: [PATCH 04/10] drm/tegra: Set fbdev flags

2023-07-05 Thread Javier Martinez Canillas
Thomas Zimmermann writes: [...] >>> + info->flags |= FBINFO_VIRTFB; >> >> I see that all fbdev drivers just do: info->flags = FBINFO_FLAG_DEFAULT | >> FBINFO_VIRTFB >> >> Guess you are doing in two assignments to be consistent with drm_fbdev_dma.c >> ? >> I was just curious about the ra

Re: [PATCH 04/10] drm/tegra: Set fbdev flags

2023-07-05 Thread Thomas Zimmermann
Hi Javier Am 05.07.23 um 10:34 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Set fbdev default flags FBNFO_DEFAULT and mark the framebuffer with FBINFO_VIRTFB. The framebuffer range is in DMA-able memory and should be accessed with the CPU's regular memory ops. Signed-off-by: T

Re: [PATCH 04/10] drm/tegra: Set fbdev flags

2023-07-05 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Set fbdev default flags FBNFO_DEFAULT and mark the framebuffer with > FBINFO_VIRTFB. The framebuffer range is in DMA-able memory and should > be accessed with the CPU's regular memory ops. > > Signed-off-by: Thomas Zimmermann > Cc: Thierry Reding > Cc: Mikko Perttune

[PATCH 04/10] drm/tegra: Set fbdev flags

2023-07-04 Thread Thomas Zimmermann
Set fbdev default flags FBNFO_DEFAULT and mark the framebuffer with FBINFO_VIRTFB. The framebuffer range is in DMA-able memory and should be accessed with the CPU's regular memory ops. Signed-off-by: Thomas Zimmermann Cc: Thierry Reding Cc: Mikko Perttunen --- drivers/gpu/drm/tegra/fbdev.c | 3