Re: [PATCH 04/10] drm/tidss: Move reset to the end of dispc_init()

2023-11-06 Thread Tomi Valkeinen
On 06/11/2023 00:54, Laurent Pinchart wrote: On Thu, Nov 02, 2023 at 08:40:10AM +0200, Tomi Valkeinen wrote: On 01/11/2023 15:57, Laurent Pinchart wrote: On Wed, Nov 01, 2023 at 11:17:41AM +0200, Tomi Valkeinen wrote: We do a DSS reset in the middle of the dispc_init(). While that happens to

Re: [PATCH 04/10] drm/tidss: Move reset to the end of dispc_init()

2023-11-05 Thread Laurent Pinchart
On Thu, Nov 02, 2023 at 08:40:10AM +0200, Tomi Valkeinen wrote: > On 01/11/2023 15:57, Laurent Pinchart wrote: > > On Wed, Nov 01, 2023 at 11:17:41AM +0200, Tomi Valkeinen wrote: > >> We do a DSS reset in the middle of the dispc_init(). While that happens > >> to work now, we should really make

Re: [PATCH 04/10] drm/tidss: Move reset to the end of dispc_init()

2023-11-02 Thread Tomi Valkeinen
On 01/11/2023 15:57, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. On Wed, Nov 01, 2023 at 11:17:41AM +0200, Tomi Valkeinen wrote: We do a DSS reset in the middle of the dispc_init(). While that happens to work now, we should really make sure that e..g the fclk, which is acquired

Re: [PATCH 04/10] drm/tidss: Move reset to the end of dispc_init()

2023-11-01 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Wed, Nov 01, 2023 at 11:17:41AM +0200, Tomi Valkeinen wrote: > We do a DSS reset in the middle of the dispc_init(). While that happens > to work now, we should really make sure that e..g the fclk, which is > acquired only later in the function, is enabled

[PATCH 04/10] drm/tidss: Move reset to the end of dispc_init()

2023-11-01 Thread Tomi Valkeinen
We do a DSS reset in the middle of the dispc_init(). While that happens to work now, we should really make sure that e..g the fclk, which is acquired only later in the function, is enabled when doing a reset. This will be handled in a later patch, but for now, let's move the dispc_softreset() call