Re: [PATCH 05/12] drm/edid: Expose mandatory stereo modes for HDMI sinks

2013-09-17 Thread Damien Lespiau
On Mon, Sep 16, 2013 at 09:29:31PM +0300, Ville Syrjälä wrote: > > +struct stereo_mandatory_mode { > > + int width, height, freq; [..] > > + unsigned int interlace_flag, layouts; > > What's the benefit of separating the two? Just that we can easily cycle through the layout flags and add a m

Re: [PATCH 05/12] drm/edid: Expose mandatory stereo modes for HDMI sinks

2013-09-16 Thread Damien Lespiau
On Mon, Sep 16, 2013 at 09:29:31PM +0300, Ville Syrjälä wrote: > > static int > > do_hdmi_vsdb_modes(struct drm_connector *connector, const u8 *db, u8 len) > > @@ -2582,10 +2662,15 @@ do_hdmi_vsdb_modes(struct drm_connector *connector, > > const u8 *db, u8 len) > > > > /* the declared leng

Re: [PATCH 05/12] drm/edid: Expose mandatory stereo modes for HDMI sinks

2013-09-16 Thread Ville Syrjälä
On Mon, Sep 16, 2013 at 06:48:48PM +0100, Damien Lespiau wrote: > For now, let's just look at the 3D_present flag of the CEA HDMI vendor > block to detect if the sink supports a small list of then mandatory 3D > formats. > > See the HDMI 1.4a 3D extraction for detail: > http://www.hdmi.org/manuf

[PATCH 05/12] drm/edid: Expose mandatory stereo modes for HDMI sinks

2013-09-16 Thread Damien Lespiau
For now, let's just look at the 3D_present flag of the CEA HDMI vendor block to detect if the sink supports a small list of then mandatory 3D formats. See the HDMI 1.4a 3D extraction for detail: http://www.hdmi.org/manufacturer/specification.aspx Signed-off-by: Damien Lespiau --- drivers/gpu/