Re: [PATCH 05/22] drm/gma500: Use simple encoder

2020-03-09 Thread Thomas Zimmermann
Hi Sam Am 06.03.20 um 22:35 schrieb Sam Ravnborg: > Hi Thomas. > > On Thu, Mar 05, 2020 at 04:59:33PM +0100, Thomas Zimmermann wrote: >> The gma500 driver uses empty implementations for some of its encoders. >> Replace the code with the generic simple encoder. > This parts looks good. > > >>

Re: [PATCH 05/22] drm/gma500: Use simple encoder

2020-03-06 Thread Sam Ravnborg
Hi Thomas. On Thu, Mar 05, 2020 at 04:59:33PM +0100, Thomas Zimmermann wrote: > The gma500 driver uses empty implementations for some of its encoders. > Replace the code with the generic simple encoder. This parts looks good. > As a side effect, the > patch also removes an indirection in the

Re: [PATCH 05/22] drm/gma500: Use simple encoder

2020-03-05 Thread kbuild test robot
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [also build test ERROR on v5.6-rc4] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2] [if your patch is applied to the

[PATCH 05/22] drm/gma500: Use simple encoder

2020-03-05 Thread Thomas Zimmermann
The gma500 driver uses empty implementations for some of its encoders. Replace the code with the generic simple encoder. As a side effect, the patch also removes an indirection in the encoder setup for Medfield. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/cdv_intel_crt.c |