Re: [PATCH 05/64] drm/connector: Mention the cleanup after drm_connector_init

2022-06-20 Thread Thomas Zimmermann
Hi Am 20.06.22 um 16:40 schrieb Maxime Ripard: On Mon, Jun 20, 2022 at 04:19:43PM +0200, Thomas Zimmermann wrote: Hi Am 20.06.22 um 14:18 schrieb Maxime Ripard: + * At driver unload time the driver's _connector_funcs.destroy hook + * should call drm_connector_unregister(),

Re: [PATCH 05/64] drm/connector: Mention the cleanup after drm_connector_init

2022-06-20 Thread Maxime Ripard
On Mon, Jun 20, 2022 at 04:19:43PM +0200, Thomas Zimmermann wrote: > Hi > > Am 20.06.22 um 14:18 schrieb Maxime Ripard: > > + * At driver unload time the driver's _connector_funcs.destroy hook > > + * should call drm_connector_unregister(), drm_connector_cleanup() and > > + * kfree() the

Re: [PATCH 05/64] drm/connector: Mention the cleanup after drm_connector_init

2022-06-20 Thread Thomas Zimmermann
Hi Am 20.06.22 um 14:18 schrieb Maxime Ripard: + * At driver unload time the driver's _connector_funcs.destroy hook + * should call drm_connector_unregister(), drm_connector_cleanup() and + * kfree() the connector structure. This sentence sounds odd. -- Thomas Zimmermann Graphics Driver

Re: [PATCH 05/64] drm/connector: Mention the cleanup after drm_connector_init

2022-06-20 Thread Maxime Ripard
Hi Thomas, Thanks for your review On Mon, Jun 20, 2022 at 12:21:33PM +0200, Thomas Zimmermann wrote: > Am 10.06.22 um 11:28 schrieb Maxime Ripard: > > Unlike encoders and CRTCs, the drm_connector_init() and > > drm_connector_init_with_ddc() don't mention how the cleanup is supposed to > > be

Re: [PATCH 05/64] drm/connector: Mention the cleanup after drm_connector_init

2022-06-20 Thread Thomas Zimmermann
Hi Am 10.06.22 um 11:28 schrieb Maxime Ripard: Unlike encoders and CRTCs, the drm_connector_init() and drm_connector_init_with_ddc() don't mention how the cleanup is supposed to be done. Let's add it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_connector.c | 10 ++ 1 file

[PATCH 05/64] drm/connector: Mention the cleanup after drm_connector_init

2022-06-10 Thread Maxime Ripard
Unlike encoders and CRTCs, the drm_connector_init() and drm_connector_init_with_ddc() don't mention how the cleanup is supposed to be done. Let's add it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_connector.c | 10 ++ 1 file changed, 10 insertions(+) diff --git