Re: [PATCH 09/10] drm/tidss: IRQ code cleanup

2023-11-02 Thread Tomi Valkeinen
On 01/11/2023 16:52, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. On Wed, Nov 01, 2023 at 11:17:46AM +0200, Tomi Valkeinen wrote: The IRQ setup code is overly complex. All we really need to do is initialize the related fields in struct tidss_device, and request the IRQ. We can

Re: [PATCH 09/10] drm/tidss: IRQ code cleanup

2023-11-01 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Wed, Nov 01, 2023 at 11:17:46AM +0200, Tomi Valkeinen wrote: > The IRQ setup code is overly complex. All we really need to do is > initialize the related fields in struct tidss_device, and request the > IRQ. > > We can drop all the HW accesses, as they are

[PATCH 09/10] drm/tidss: IRQ code cleanup

2023-11-01 Thread Tomi Valkeinen
The IRQ setup code is overly complex. All we really need to do is initialize the related fields in struct tidss_device, and request the IRQ. We can drop all the HW accesses, as they are pointless: the driver will set the IRQs correctly when it needs any of the IRQs, and at probe time we have done