[Intel-gfx] [PATCH 09/10] i915: add DP 1.2 MST support (v0.3)

2014-05-14 Thread Daniel Vetter
On Wed, May 14, 2014 at 08:05:11AM +0200, David Herrmann wrote: > Hi > > On Wed, May 14, 2014 at 2:03 AM, Dave Airlie wrote: > > Since any objects you get with find are only valid under mode_config.mutex, > > yes some drivers mess this up, but they should be fixed. > > Didn't know that we have

[PATCH 09/10] i915: add DP 1.2 MST support (v0.3)

2014-05-14 Thread Dave Airlie
> > So we leak all dynamically created objects? There's no > kfree(intel_connector) here and we cannot add it because > drm_mode_object_find() is not ref-counted. So we keep the connector in > the mode_group and wait until the final drm_mode_config_cleanup()? But > drm_connector_cleanup() already

[PATCH 09/10] i915: add DP 1.2 MST support (v0.3)

2014-05-14 Thread David Herrmann
Hi On Wed, May 14, 2014 at 2:03 AM, Dave Airlie wrote: > Since any objects you get with find are only valid under mode_config.mutex, > yes some drivers mess this up, but they should be fixed. Didn't know that we have such a rule. Then it's fine, of course. The page-flip code is what worried me,

[PATCH 09/10] i915: add DP 1.2 MST support (v0.3)

2014-05-13 Thread David Herrmann
Hi Dave On Mon, May 12, 2014 at 8:46 AM, Dave Airlie wrote: > From: Dave Airlie > > This adds DP 1.2 MST support on Haswell systems. > > Notes: > a) this reworks irq handling for DP MST ports, so that we can > avoid the mode config locking in the current hpd handlers, as > we need to process

[PATCH 09/10] i915: add DP 1.2 MST support (v0.3)

2014-05-12 Thread Dave Airlie
From: Dave Airlie This adds DP 1.2 MST support on Haswell systems. Notes: a) this reworks irq handling for DP MST ports, so that we can avoid the mode config locking in the current hpd handlers, as we need to process up/down msgs at a better time. b) it introduces a new MST