Re: [PATCH 1/1] Support LVDS output on Allwinner A20

2020-02-17 Thread Maxime Ripard
On Thu, Feb 13, 2020 at 08:11:10PM +0200, Andrey Lebedev wrote: > On Thu, Feb 13, 2020 at 10:24:33AM +0100, Maxime Ripard wrote: > > > > do you have a board when you have been able to test it? > > > > > > Yes, I have the hardware (Cubieboard 2) at hand, but I cannot change the > > > any physical co

Re: [PATCH 1/1] Support LVDS output on Allwinner A20

2020-02-14 Thread Andrey Lebedev
On Thu, Feb 13, 2020 at 10:24:33AM +0100, Maxime Ripard wrote: > > > do you have a board when you have been able to test it? > > > > Yes, I have the hardware (Cubieboard 2) at hand, but I cannot change the > > any physical connections on it. FWIW, it is https://openvario.org, the > > device we are

Re: [PATCH 1/1] Support LVDS output on Allwinner A20

2020-02-14 Thread Maxime Ripard
On Thu, Feb 13, 2020 at 12:46:53AM +0200, Andrey Lebedev wrote: > On Wed, Feb 12, 2020 at 01:53:45PM +0100, Maxime Ripard wrote: > > > > Side question, this will need some DT changes too, right? > > > > > > Hm, I agree. I think it would be reasonable to include LVDS0/1 pins > > > > That, but most i

Re: [PATCH 1/1] Support LVDS output on Allwinner A20

2020-02-13 Thread Maxime Ripard
Hi Andrey, On Tue, Feb 11, 2020 at 10:48:28PM +0200, Andrey Lebedev wrote: > Maxime, thanks for your comments. I'll update the patch, but meanwhile, > I have some remarks/questions, see below. > > On Tue, Feb 11, 2020 at 08:20:04AM +0100, Maxime Ripard wrote: > > > + regmap_update_bits(tcon->regs,

Re: [PATCH 1/1] Support LVDS output on Allwinner A20

2020-02-13 Thread Andrey Lebedev
On Wed, Feb 12, 2020 at 01:53:45PM +0100, Maxime Ripard wrote: > > > Side question, this will need some DT changes too, right? > > > > Hm, I agree. I think it would be reasonable to include LVDS0/1 pins > > That, but most importantly, the reset and clocks for the LVDS > block. Also from looking at

Re: [PATCH 1/1] Support LVDS output on Allwinner A20

2020-02-12 Thread Andrey Lebedev
Maxime, thanks for your comments. I'll update the patch, but meanwhile, I have some remarks/questions, see below. On Tue, Feb 11, 2020 at 08:20:04AM +0100, Maxime Ripard wrote: > > + regmap_update_bits(tcon->regs, SUN4I_TCON0_LVDS_ANA1_REG, > > + SUN4I_TCON0_LVDS_ANA1_UPDATE

[PATCH 1/1] Support LVDS output on Allwinner A20

2020-02-10 Thread Andrey Lebedev
A20 SoC (found in Cubieboard 2 among others) requires different LVDS set up procedure than A33. Timing controller (tcon) driver only implements sun6i-style procedure, that doesn't work on A20 (sun7i). The support for such procedure is ported from u-boot and follows u-boot naming convention: SUN6I*

Re: [PATCH 1/1] Support LVDS output on Allwinner A20

2020-02-10 Thread Maxime Ripard
Hi, On Mon, Feb 10, 2020 at 09:56:33PM +0200, Andrey Lebedev wrote: > A20 SoC (found in Cubieboard 2 among others) requires different LVDS set > up procedure than A33. Timing controller (tcon) driver only implements > sun6i-style procedure, that doesn't work on A20 (sun7i). You're missing your Si