Re: [PATCH 1/1] drm/sun4i: hdmi: Check for null pointer before cleanup

Hi, On 12/17/19 1:49 PM, Maxime Ripard wrote: On Tue, Dec 17, 2019 at 12:46:03PM +0100, Maxime Ripard wrote: On Tue, Dec 17, 2019 at 08:45:07AM +0200, Stefan Mavrodiev wrote: Hi, On 12/16/19 6:12 PM, Maxime Ripard wrote: Hi, On Mon, Dec 16, 2019 at 04:43:48PM +0200, Stefan Mavrodiev wrote:

Re: [PATCH 1/1] drm/sun4i: hdmi: Check for null pointer before cleanup

On Tue, Dec 17, 2019 at 01:54:56PM +0200, Stefan Mavrodiev wrote: > Hi, > > On 12/17/19 1:49 PM, Maxime Ripard wrote: > > On Tue, Dec 17, 2019 at 12:46:03PM +0100, Maxime Ripard wrote: > > > On Tue, Dec 17, 2019 at 08:45:07AM +0200, Stefan Mavrodiev wrote: > > > > Hi, > > > > > > > > On 12/16/19

Re: [PATCH 1/1] drm/sun4i: hdmi: Check for null pointer before cleanup

On Tue, Dec 17, 2019 at 12:46:03PM +0100, Maxime Ripard wrote: > On Tue, Dec 17, 2019 at 08:45:07AM +0200, Stefan Mavrodiev wrote: > > Hi, > > > > On 12/16/19 6:12 PM, Maxime Ripard wrote: > > > Hi, > > > > > > On Mon, Dec 16, 2019 at 04:43:48PM +0200, Stefan Mavrodiev wrote: > > > > It's possible

Re: [PATCH 1/1] drm/sun4i: hdmi: Check for null pointer before cleanup

On Tue, Dec 17, 2019 at 08:45:07AM +0200, Stefan Mavrodiev wrote: > Hi, > > On 12/16/19 6:12 PM, Maxime Ripard wrote: > > Hi, > > > > On Mon, Dec 16, 2019 at 04:43:48PM +0200, Stefan Mavrodiev wrote: > > > It's possible hdmi->connector and hdmi->encoder divices to be NULL. > > > This can happen

[PATCH 1/1] drm/sun4i: hdmi: Check for null pointer before cleanup

It's possible hdmi->connector and hdmi->encoder divices to be NULL. This can happen when building as kernel module and you try to remove the module. This patch make simple null check, before calling the cleanup functions. Signed-off-by: Stefan Mavrodiev ---

Re: [PATCH 1/1] drm/sun4i: hdmi: Check for null pointer before cleanup

Hi, On 12/16/19 6:12 PM, Maxime Ripard wrote: Hi, On Mon, Dec 16, 2019 at 04:43:48PM +0200, Stefan Mavrodiev wrote: It's possible hdmi->connector and hdmi->encoder divices to be NULL. This can happen when building as kernel module and you try to remove the module. This patch make simple null

Re: [PATCH 1/1] drm/sun4i: hdmi: Check for null pointer before cleanup

On Mon, Dec 16, 2019 at 04:43:48PM +0200, Stefan Mavrodiev wrote: > It's possible hdmi->connector and hdmi->encoder divices to be NULL. The wording is broken and s/divices/devices/. I'd write: It's possible that the parent devices of the connector and/or encoder are NULL. This

Re: [PATCH 1/1] drm/sun4i: hdmi: Check for null pointer before cleanup

Hi, On Mon, Dec 16, 2019 at 04:43:48PM +0200, Stefan Mavrodiev wrote: > It's possible hdmi->connector and hdmi->encoder divices to be NULL. > This can happen when building as kernel module and you try to remove > the module. > > This patch make simple null check, before calling the cleanup