Re: [PATCH 1/1] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2022-08-13 Thread kernel test robot
Hi Olivier, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm-tip/drm-tip linus/master v5.19 next-20220812] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH 1/1] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2022-08-13 Thread Sumit Garg
Hi Olivier, On Thu, 11 Aug 2022 at 19:26, Olivier Masse wrote: > > From: Etienne Carriere > > This change allows userland to create a tee_shm object that refers > to a dmabuf reference. > > Userland provides a dmabuf file descriptor as buffer reference. > The created tee_shm object exported as

[PATCH 1/1] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2022-08-12 Thread Olivier Masse
From: Etienne Carriere This change allows userland to create a tee_shm object that refers to a dmabuf reference. Userland provides a dmabuf file descriptor as buffer reference. The created tee_shm object exported as a brand new dmabuf reference used to provide a clean fd to userland. Userland

Re: [EXT] Re: [PATCH 1/1] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2022-08-12 Thread Olivier Masse
Hi Sumit, Thanks for your comments, please find my answer below. On ven., 2022-08-12 at 19:36 +0530, Sumit Garg wrote: > Caution: EXT Email > > Hi Olivier, > > On Thu, 11 Aug 2022 at 19:26, Olivier Masse > wrote: > > > > From: Etienne Carriere > > > > This change allows userland to create

Re: [EXT] Re: [PATCH 1/1] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2022-08-12 Thread Olivier Masse
Hi Christian, On ven., 2022-08-12 at 12:18 +0200, Christian König wrote: > Caution: EXT Email > > Hi Etienne, > > at least I don't see anything obvious broken. > > Just two comments: > > 1. Dmitry is working on a change which renames some functions and > makes > it mandatory to call them with

Re: [PATCH 1/1] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2022-08-12 Thread Christian König
Hi Etienne, at least I don't see anything obvious broken. Just two comments: 1. Dmitry is working on a change which renames some functions and makes it mandatory to call them with the dma_resv lock held. Depending on how you want to upstream this change you will certainly run into

Re: [PATCH 1/1] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2022-08-11 Thread kernel test robot
Hi Olivier, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm-tip/drm-tip linus/master v5.19 next-20220811] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

[PATCH 1/1] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2022-08-11 Thread Olivier Masse
From: Etienne Carriere This change allows userland to create a tee_shm object that refers to a dmabuf reference. Userland provides a dmabuf file descriptor as buffer reference. The created tee_shm object exported as a brand new dmabuf reference used to provide a clean fd to userland. Userland