Re: [PATCH 1/2] drm/msm/dpu: drop SSPP register dumpers

2023-06-14 Thread Marijn Suijten
On 2023-06-14 12:39:13, Marijn Suijten wrote: > > > > - /* add register dump support */ > > > > - dpu_debugfs_create_regset32("src_blk", 0400, > > > > - debugfs_root, > > > > - sblk->src_blk.base + cfg->base, > > > > -

Re: [PATCH 1/2] drm/msm/dpu: drop SSPP register dumpers

2023-06-14 Thread Marijn Suijten
On 2023-05-21 21:16:39, Marijn Suijten wrote: > On 2023-05-21 20:12:00, Marijn Suijten wrote: > > On 2023-05-21 20:21:46, Dmitry Baryshkov wrote: > > > Drop SSPP-specifig debugfs register dumps in favour of using > > > debugfs/dri/0/kms or devcoredump. > > > > > > Signed-off-by: Dmitry Baryshkov

Re: [PATCH 1/2] drm/msm/dpu: drop SSPP register dumpers

2023-06-04 Thread Marijn Suijten
On 2023-05-30 23:14:19, Dmitry Baryshkov wrote: > On Tue, 30 May 2023 at 20:37, Abhinav Kumar wrote: > > > > > > > > On 5/29/2023 2:36 PM, Marijn Suijten wrote: > > > On 2023-05-24 12:18:09, Abhinav Kumar wrote: > > >> > > >> > > >> On 5/24/2023 2:48 AM, Marijn Suijten wrote: > > >>> On

Re: [PATCH 1/2] drm/msm/dpu: drop SSPP register dumpers

2023-05-30 Thread Dmitry Baryshkov
On Tue, 30 May 2023 at 20:37, Abhinav Kumar wrote: > > > > On 5/29/2023 2:36 PM, Marijn Suijten wrote: > > On 2023-05-24 12:18:09, Abhinav Kumar wrote: > >> > >> > >> On 5/24/2023 2:48 AM, Marijn Suijten wrote: > >>> On 2023-05-23 13:01:13, Abhinav Kumar wrote: > > > On 5/21/2023

Re: [PATCH 1/2] drm/msm/dpu: drop SSPP register dumpers

2023-05-30 Thread Abhinav Kumar
On 5/29/2023 2:36 PM, Marijn Suijten wrote: On 2023-05-24 12:18:09, Abhinav Kumar wrote: On 5/24/2023 2:48 AM, Marijn Suijten wrote: On 2023-05-23 13:01:13, Abhinav Kumar wrote: On 5/21/2023 10:21 AM, Dmitry Baryshkov wrote: Drop SSPP-specifig debugfs register dumps in favour of using

Re: [PATCH 1/2] drm/msm/dpu: drop SSPP register dumpers

2023-05-29 Thread Marijn Suijten
On 2023-05-24 12:18:09, Abhinav Kumar wrote: > > > On 5/24/2023 2:48 AM, Marijn Suijten wrote: > > On 2023-05-23 13:01:13, Abhinav Kumar wrote: > >> > >> > >> On 5/21/2023 10:21 AM, Dmitry Baryshkov wrote: > >>> Drop SSPP-specifig debugfs register dumps in favour of using > >>> debugfs/dri/0/kms

Re: [PATCH 1/2] drm/msm/dpu: drop SSPP register dumpers

2023-05-24 Thread Abhinav Kumar
On 5/24/2023 2:48 AM, Marijn Suijten wrote: On 2023-05-23 13:01:13, Abhinav Kumar wrote: On 5/21/2023 10:21 AM, Dmitry Baryshkov wrote: Drop SSPP-specifig debugfs register dumps in favour of using debugfs/dri/0/kms or devcoredump. I did see another series which removes src_blk from the

Re: [PATCH 1/2] drm/msm/dpu: drop SSPP register dumpers

2023-05-24 Thread Dmitry Baryshkov
On Wed, 24 May 2023 at 12:48, Marijn Suijten wrote: > > On 2023-05-23 13:01:13, Abhinav Kumar wrote: > > > > > > On 5/21/2023 10:21 AM, Dmitry Baryshkov wrote: > > > Drop SSPP-specifig debugfs register dumps in favour of using > > > debugfs/dri/0/kms or devcoredump. > > > > > > > I did see

Re: [PATCH 1/2] drm/msm/dpu: drop SSPP register dumpers

2023-05-24 Thread Marijn Suijten
On 2023-05-23 13:01:13, Abhinav Kumar wrote: > > > On 5/21/2023 10:21 AM, Dmitry Baryshkov wrote: > > Drop SSPP-specifig debugfs register dumps in favour of using > > debugfs/dri/0/kms or devcoredump. > > > > I did see another series which removes src_blk from the catalog (I am > yet to

Re: [PATCH 1/2] drm/msm/dpu: drop SSPP register dumpers

2023-05-23 Thread Dmitry Baryshkov
On Tue, 23 May 2023 at 23:01, Abhinav Kumar wrote: > > > > On 5/21/2023 10:21 AM, Dmitry Baryshkov wrote: > > Drop SSPP-specifig debugfs register dumps in favour of using > > debugfs/dri/0/kms or devcoredump. > > > > I did see another series which removes src_blk from the catalog (I am > yet to

Re: [PATCH 1/2] drm/msm/dpu: drop SSPP register dumpers

2023-05-23 Thread Abhinav Kumar
On 5/21/2023 10:21 AM, Dmitry Baryshkov wrote: Drop SSPP-specifig debugfs register dumps in favour of using debugfs/dri/0/kms or devcoredump. I did see another series which removes src_blk from the catalog (I am yet to review that one) . Lets assume that one is fine and this change will

Re: [PATCH 1/2] drm/msm/dpu: drop SSPP register dumpers

2023-05-21 Thread Marijn Suijten
On 2023-05-21 20:12:00, Marijn Suijten wrote: > On 2023-05-21 20:21:46, Dmitry Baryshkov wrote: > > Drop SSPP-specifig debugfs register dumps in favour of using > > debugfs/dri/0/kms or devcoredump. > > > > Signed-off-by: Dmitry Baryshkov > > Reviewed-by: Marijn Suijten > > > --- > >

Re: [PATCH 1/2] drm/msm/dpu: drop SSPP register dumpers

2023-05-21 Thread Marijn Suijten
On 2023-05-21 20:21:46, Dmitry Baryshkov wrote: > Drop SSPP-specifig debugfs register dumps in favour of using > debugfs/dri/0/kms or devcoredump. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 25 - >

[PATCH 1/2] drm/msm/dpu: drop SSPP register dumpers

2023-05-21 Thread Dmitry Baryshkov
Drop SSPP-specifig debugfs register dumps in favour of using debugfs/dri/0/kms or devcoredump. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 25 - 1 file changed, 25 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c