Re: [PATCH 1/2] drm/shmem: add support for per object dma api operations

2020-06-22 Thread Gurchetan Singh
On Mon, Jun 15, 2020 at 12:21 AM Gerd Hoffmann wrote: > > On Fri, Jun 12, 2020 at 11:54:54AM -0700, Gurchetan Singh wrote: > > > Plus, I just realized the virtio dma ops and ops used by drm shmem are > > different, so virtio would have to unconditionally have to skip the > > shmem path. Perhaps

Re: [PATCH 1/2] drm/shmem: add support for per object dma api operations

2020-06-15 Thread Gerd Hoffmann
On Fri, Jun 12, 2020 at 11:54:54AM -0700, Gurchetan Singh wrote: > Plus, I just realized the virtio dma ops and ops used by drm shmem are > different, so virtio would have to unconditionally have to skip the > shmem path. Perhaps the best policy is to revert d323bb44e4d2? Reverting d323bb44e4d2

Re: [PATCH 1/2] drm/shmem: add support for per object dma api operations

2020-06-15 Thread Thomas Zimmermann
Hi Am 12.06.20 um 20:54 schrieb Gurchetan Singh: > On Fri, Jun 12, 2020 at 3:17 AM Gerd Hoffmann wrote: >> >> On Fri, Jun 12, 2020 at 11:47:55AM +0200, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 12.06.20 um 03:36 schrieb Gurchetan Singh: This is useful for the next patch. Also, should we

Re: [PATCH 1/2] drm/shmem: add support for per object dma api operations

2020-06-12 Thread Gurchetan Singh
On Fri, Jun 12, 2020 at 3:17 AM Gerd Hoffmann wrote: > > On Fri, Jun 12, 2020 at 11:47:55AM +0200, Thomas Zimmermann wrote: > > Hi > > > > Am 12.06.20 um 03:36 schrieb Gurchetan Singh: > > > This is useful for the next patch. Also, should we only unmap the > > > amount entries that we mapped

Re: [PATCH 1/2] drm/shmem: add support for per object dma api operations

2020-06-12 Thread Daniel Vetter
On Fri, Jun 12, 2020 at 12:16 PM Gerd Hoffmann wrote: > > On Fri, Jun 12, 2020 at 11:47:55AM +0200, Thomas Zimmermann wrote: > > Hi > > > > Am 12.06.20 um 03:36 schrieb Gurchetan Singh: > > > This is useful for the next patch. Also, should we only unmap the > > > amount entries that we mapped

Re: [PATCH 1/2] drm/shmem: add support for per object dma api operations

2020-06-12 Thread Gerd Hoffmann
On Fri, Jun 12, 2020 at 11:47:55AM +0200, Thomas Zimmermann wrote: > Hi > > Am 12.06.20 um 03:36 schrieb Gurchetan Singh: > > This is useful for the next patch. Also, should we only unmap the > > amount entries that we mapped with the dma-api? > > It looks like you're moving virtio code into

Re: [PATCH 1/2] drm/shmem: add support for per object dma api operations

2020-06-12 Thread Thomas Zimmermann
Hi Am 12.06.20 um 03:36 schrieb Gurchetan Singh: > This is useful for the next patch. Also, should we only unmap the > amount entries that we mapped with the dma-api? It looks like you're moving virtio code into shmem. It would be nice to have a cover letter explaining the series. > >

[PATCH 1/2] drm/shmem: add support for per object dma api operations

2020-06-11 Thread Gurchetan Singh
This is useful for the next patch. Also, should we only unmap the amount entries that we mapped with the dma-api? Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/drm_gem_shmem_helper.c | 16 +++- include/drm/drm_gem_shmem_helper.h | 10 ++ 2 files changed, 21