Re: [PATCH 1/2] drm: Implement vm_operations_struct.access

2017-07-15 Thread Christian König
Am 15.07.2017 um 05:32 schrieb Michel Dänzer: On 15/07/17 04:47 AM, Felix Kuehling wrote: On 17-07-13 11:26 PM, Michel Dänzer wrote: On 14/07/17 06:08 AM, Felix Kuehling wrote: Allows gdb to access contents of user mode mapped BOs. VRAM access requires the driver to implement a new callback in

Re: [PATCH 1/2] drm: Implement vm_operations_struct.access

2017-07-14 Thread Michel Dänzer
On 15/07/17 04:47 AM, Felix Kuehling wrote: > On 17-07-13 11:26 PM, Michel Dänzer wrote: >> On 14/07/17 06:08 AM, Felix Kuehling wrote: >>> Allows gdb to access contents of user mode mapped BOs. VRAM access >>> requires the driver to implement a new callback in ttm_bo_driver. >> Thanks for doing th

Re: [PATCH 1/2] drm: Implement vm_operations_struct.access

2017-07-14 Thread Felix Kuehling
On 17-07-13 11:26 PM, Michel Dänzer wrote: > On 14/07/17 06:08 AM, Felix Kuehling wrote: >> Allows gdb to access contents of user mode mapped BOs. VRAM access >> requires the driver to implement a new callback in ttm_bo_driver. > Thanks for doing this. Looks mostly good, but I still have some comme

Re: [PATCH 1/2] drm: Implement vm_operations_struct.access

2017-07-14 Thread Felix Kuehling
On 17-07-14 06:06 AM, Christian König wrote: > Am 13.07.2017 um 23:08 schrieb Felix Kuehling: >> Allows gdb to access contents of user mode mapped BOs. VRAM access >> requires the driver to implement a new callback in ttm_bo_driver. > > One more comment additionally to what Michel already wrote bel

Re: [PATCH 1/2] drm: Implement vm_operations_struct.access

2017-07-14 Thread Christian König
Am 13.07.2017 um 23:08 schrieb Felix Kuehling: Allows gdb to access contents of user mode mapped BOs. VRAM access requires the driver to implement a new callback in ttm_bo_driver. One more comment additionally to what Michel already wrote below, apart from that it looks good to me. Signed-

Re: [PATCH 1/2] drm: Implement vm_operations_struct.access

2017-07-13 Thread Michel Dänzer
On 14/07/17 06:08 AM, Felix Kuehling wrote: > Allows gdb to access contents of user mode mapped BOs. VRAM access > requires the driver to implement a new callback in ttm_bo_driver. Thanks for doing this. Looks mostly good, but I still have some comments. The shortlog prefix should be "drm/ttm:".

[PATCH 1/2] drm: Implement vm_operations_struct.access

2017-07-13 Thread Felix Kuehling
Allows gdb to access contents of user mode mapped BOs. VRAM access requires the driver to implement a new callback in ttm_bo_driver. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 66 - include/drm/ttm/ttm_bo_driver.h | 12 2