Re: [PATCH 1/2] drm: rcar-du: Refactor Feature and Quirk definitions

2018-08-23 Thread Simon Horman
On Mon, Aug 20, 2018 at 05:00:43PM +0100, Kieran Bingham wrote: > These flags are represented by bit fields. To make this clear, utilise > the BIT() macro. > > Signed-off-by: Kieran Bingham > > --- > This patch fails checkpatch's 80-char limit, due to the line comments > extending across the

Re: [PATCH 1/2] drm: rcar-du: Refactor Feature and Quirk definitions

2018-08-20 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Monday, 20 August 2018 19:00:43 EEST Kieran Bingham wrote: > These flags are represented by bit fields. To make this clear, utilise > the BIT() macro. > > Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart > --- > This patch fails checkpatch's

[PATCH 1/2] drm: rcar-du: Refactor Feature and Quirk definitions

2018-08-20 Thread Kieran Bingham
These flags are represented by bit fields. To make this clear, utilise the BIT() macro. Signed-off-by: Kieran Bingham --- This patch fails checkpatch's 80-char limit, due to the line comments extending across the 80-char boundary on RCAR_DU_FEATURE_EXT_CTRL_REGS To preserve formatting - this