Re: [PATCH 1/2] drm: ssd130x: Fix COM scan direction register mask

2022-03-09 Thread Javier Martinez Canillas
On 3/9/22 13:56, Geert Uytterhoeven wrote: > On Wed, Mar 9, 2022 at 2:57 AM Chen-Yu Tsai wrote: >> From: Chen-Yu Tsai >> >> The SSD130x's command to toggle COM scan direction uses bit 3 and only >> bit 3 to set the direction of the scanout. The driver has an incorrect >> GENMASK(3, 2), causing

Re: [PATCH 1/2] drm: ssd130x: Fix COM scan direction register mask

2022-03-09 Thread Geert Uytterhoeven
On Wed, Mar 9, 2022 at 2:57 AM Chen-Yu Tsai wrote: > From: Chen-Yu Tsai > > The SSD130x's command to toggle COM scan direction uses bit 3 and only > bit 3 to set the direction of the scanout. The driver has an incorrect > GENMASK(3, 2), causing the setting to be set on bit 2, rendering it >

Re: [PATCH 1/2] drm: ssd130x: Fix COM scan direction register mask

2022-03-08 Thread Javier Martinez Canillas
Hello Chen-Yu, Thanks a lot for your patch. On 3/8/22 17:07, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai > > The SSD130x's command to toggle COM scan direction uses bit 3 and only > bit 3 to set the direction of the scanout. The driver has an incorrect > GENMASK(3, 2), causing the setting to be

[PATCH 1/2] drm: ssd130x: Fix COM scan direction register mask

2022-03-08 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The SSD130x's command to toggle COM scan direction uses bit 3 and only bit 3 to set the direction of the scanout. The driver has an incorrect GENMASK(3, 2), causing the setting to be set on bit 2, rendering it ineffective. Fix the mask to only bit 3, so that the requested