Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

2024-06-18 Thread Maxime Ripard
Hi, On Fri, Feb 16, 2024 at 06:48:55PM GMT, Dave Stevenson wrote: > From: Nick Hollinghurst > > Add this as a value for enum_drm_connector_tv_mode, represented > by the string "Mono", to generate video with no colour encoding > or bursts. Define it to have no pedestal (since only NTSC-M calls >

Re: (subset) [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

2024-06-18 Thread Maxime Ripard
On Fri, 16 Feb 2024 18:48:55 +, Dave Stevenson wrote: > Add this as a value for enum_drm_connector_tv_mode, represented > by the string "Mono", to generate video with no colour encoding > or bursts. Define it to have no pedestal (since only NTSC-M calls > for a pedestal). > > Change default

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

2024-06-17 Thread Daniel Vetter
On Fri, Jun 14, 2024 at 11:01:45AM +0200, Daniel Vetter wrote: > On Thu, May 23, 2024 at 04:51:25PM +0200, Maxime Ripard wrote: > > Hi, > > > > Reviving this thread because I'm not sure what the outcome was. > > > > On Thu, Feb 29, 2024 at 11:52:12AM GMT, Daniel Vetter wrote: > > > > The only

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

2024-06-14 Thread Daniel Vetter
On Thu, May 23, 2024 at 04:51:25PM +0200, Maxime Ripard wrote: > Hi, > > Reviving this thread because I'm not sure what the outcome was. > > On Thu, Feb 29, 2024 at 11:52:12AM GMT, Daniel Vetter wrote: > > > The only thing I'm saying is that this breaks the usual DRM requirements. > > > If, as a

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

2024-05-23 Thread Simon Ser
On Thursday, February 29th, 2024 at 11:52, Daniel Vetter wrote: > I think some weston (or whatever compositor you like) config file support > to set a bunch of "really only way to configure is by hand" output > properties would clear the bar here for me. Because that is a feature I > already

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

2024-05-23 Thread Maxime Ripard
Hi, Reviving this thread because I'm not sure what the outcome was. On Thu, Feb 29, 2024 at 11:52:12AM GMT, Daniel Vetter wrote: > > The only thing I'm saying is that this breaks the usual DRM requirements. > > If, as a maintainer, you're fine with breaking the rules and have a good > >

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

2024-02-29 Thread Maxime Ripard
Hi Simon, On Wed, Feb 28, 2024 at 04:22:56PM +, Simon Ser wrote: > On Wednesday, February 28th, 2024 at 17:14, Maxime Ripard > wrote: > > > > I don't know what the rules were 8 years ago, but the current uAPI rules > > > are what they are, and a new enum entry is new uAPI. > > > > TBF,

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

2024-02-29 Thread Daniel Vetter
On Wed, Feb 28, 2024 at 04:22:56PM +, Simon Ser wrote: > On Wednesday, February 28th, 2024 at 17:14, Maxime Ripard > wrote: > > > > I don't know what the rules were 8 years ago, but the current uAPI rules > > > are what they are, and a new enum entry is new uAPI. > > > > TBF, and even if

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

2024-02-28 Thread Simon Ser
On Wednesday, February 28th, 2024 at 17:14, Maxime Ripard wrote: > > I don't know what the rules were 8 years ago, but the current uAPI rules > > are what they are, and a new enum entry is new uAPI. > > TBF, and even if the wayland compositors support is missing, this > property is perfectly

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

2024-02-28 Thread Maxime Ripard
Hi, On Tue, Feb 27, 2024 at 09:51:06AM +, Simon Ser wrote: > On Monday, February 26th, 2024 at 18:23, Dave Stevenson > wrote: > > > and I've also completely missed any kernel command line > > > arguments manipulating KMS properties. > > > > "tv_mode" on the command line is handled in > >

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

2024-02-27 Thread Pekka Paalanen
On Mon, 26 Feb 2024 17:23:24 + Dave Stevenson wrote: > Hi Pekka > > Sorry for the slight delay in replying. > > On Mon, 26 Feb 2024 at 15:11, Pekka Paalanen > wrote: > > > > On Mon, 26 Feb 2024 15:10:45 +0100 > > Maxime Ripard wrote: > > > > > Hi Pekka, > > > > > > On Wed, Feb 21, 2024

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

2024-02-27 Thread Simon Ser
On Monday, February 26th, 2024 at 18:23, Dave Stevenson wrote: > You want the commit text for a patch adding a new enum to state that > the whole property isn't expected to be used through the UAPI? OK, I > can roll a v2 if that is your desire. By definition, anything new exposed by the kernel

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

2024-02-26 Thread Dave Stevenson
Hi Pekka Sorry for the slight delay in replying. On Mon, 26 Feb 2024 at 15:11, Pekka Paalanen wrote: > > On Mon, 26 Feb 2024 15:10:45 +0100 > Maxime Ripard wrote: > > > Hi Pekka, > > > > On Wed, Feb 21, 2024 at 11:07:51AM +0200, Pekka Paalanen wrote: > > > On Fri, 16 Feb 2024 18:48:55 + >

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

2024-02-26 Thread Pekka Paalanen
On Mon, 26 Feb 2024 15:10:45 +0100 Maxime Ripard wrote: > Hi Pekka, > > On Wed, Feb 21, 2024 at 11:07:51AM +0200, Pekka Paalanen wrote: > > On Fri, 16 Feb 2024 18:48:55 + > > Dave Stevenson wrote: > > > > > From: Nick Hollinghurst > > > > > > Add this as a value for

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

2024-02-26 Thread Maxime Ripard
Hi Pekka, On Wed, Feb 21, 2024 at 11:07:51AM +0200, Pekka Paalanen wrote: > On Fri, 16 Feb 2024 18:48:55 + > Dave Stevenson wrote: > > > From: Nick Hollinghurst > > > > Add this as a value for enum_drm_connector_tv_mode, represented > > by the string "Mono", to generate video with no

Re: UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

2024-02-21 Thread Harry Wentland
On 2024-02-21 04:07, Pekka Paalanen wrote: > On Fri, 16 Feb 2024 18:48:55 + > Dave Stevenson wrote: > >> From: Nick Hollinghurst >> >> Add this as a value for enum_drm_connector_tv_mode, represented >> by the string "Mono", to generate video with no colour encoding >> or bursts. Define

UAPI Re: [PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

2024-02-21 Thread Pekka Paalanen
On Fri, 16 Feb 2024 18:48:55 + Dave Stevenson wrote: > From: Nick Hollinghurst > > Add this as a value for enum_drm_connector_tv_mode, represented > by the string "Mono", to generate video with no colour encoding > or bursts. Define it to have no pedestal (since only NTSC-M calls > for a

[PATCH 1/3] drm: Add DRM_MODE_TV_MODE_MONOCHROME

2024-02-16 Thread Dave Stevenson
From: Nick Hollinghurst Add this as a value for enum_drm_connector_tv_mode, represented by the string "Mono", to generate video with no colour encoding or bursts. Define it to have no pedestal (since only NTSC-M calls for a pedestal). Change default mode creation to acommodate the new tv_mode