[PATCH 1/3] drm: Send pending vblank events before disabling vblank.

2011-04-28 Thread Christopher James Halse Rogers
On Wed, 2011-04-27 at 11:08 +0200, Michel D?nzer wrote: > On Mit, 2011-04-27 at 18:58 +1000, Christopher James Halse Rogers > wrote: > > On Wed, 2011-04-27 at 10:32 +0200, Michel D?nzer wrote: > > > On Mit, 2011-04-27 at 16:10 +1000, christopher.halse.rogers at > > > canonical.com wrote: > > > >

Re: [PATCH 1/3] drm: Send pending vblank events before disabling vblank.

2011-04-28 Thread Jesse Barnes
On Thu, 28 Apr 2011 13:46:30 -0700 Jesse Barnes wrote: > On Thu, 28 Apr 2011 18:09:58 +1000 > Christopher James Halse Rogers > wrote: > > Ok. This appears to be surprisingly difficult. Particularly, the > > vblank code indexes crtcs based on the driver-private numbering, and > > there doesn't

[PATCH 1/3] drm: Send pending vblank events before disabling vblank.

2011-04-28 Thread Jesse Barnes
On Thu, 28 Apr 2011 13:46:30 -0700 Jesse Barnes wrote: > On Thu, 28 Apr 2011 18:09:58 +1000 > Christopher James Halse Rogers > wrote: > > Ok. This appears to be surprisingly difficult. Particularly, the > > vblank code indexes crtcs based on the driver-private numbering, and > > there doesn't

Re: [PATCH 1/3] drm: Send pending vblank events before disabling vblank.

2011-04-28 Thread Jesse Barnes
On Thu, 28 Apr 2011 18:09:58 +1000 Christopher James Halse Rogers wrote: > Ok. This appears to be surprisingly difficult. Particularly, the > vblank code indexes crtcs based on the driver-private numbering, and > there doesn't appear to be a generic interface to grab this number; > Intel uses th

[PATCH 1/3] drm: Send pending vblank events before disabling vblank.

2011-04-28 Thread Jesse Barnes
On Thu, 28 Apr 2011 18:09:58 +1000 Christopher James Halse Rogers wrote: > Ok. This appears to be surprisingly difficult. Particularly, the > vblank code indexes crtcs based on the driver-private numbering, and > there doesn't appear to be a generic interface to grab this number; > Intel uses th

Re: [PATCH 1/3] drm: Send pending vblank events before disabling vblank.

2011-04-28 Thread Jesse Barnes
On Wed, 27 Apr 2011 10:32:36 +0200 Michel Dänzer wrote: > On Mit, 2011-04-27 at 16:10 +1000, christopher.halse.rog...@canonical.com > wrote: > > From: Christopher James Halse Rogers > > > > > > This is the least-bad behaviour. It means that we signal the > > vblank event before it actually h

[PATCH 1/3] drm: Send pending vblank events before disabling vblank.

2011-04-28 Thread Jesse Barnes
On Wed, 27 Apr 2011 10:32:36 +0200 Michel D?nzer wrote: > On Mit, 2011-04-27 at 16:10 +1000, christopher.halse.rogers at canonical.com > wrote: > > From: Christopher James Halse Rogers > canonical.com> > > > > This is the least-bad behaviour. It means that we signal the > > vblank event befor

Re: [PATCH 1/3] drm: Send pending vblank events before disabling vblank.

2011-04-28 Thread Jesse Barnes
On Wed, 27 Apr 2011 16:10:57 +1000 christopher.halse.rog...@canonical.com wrote: > From: Christopher James Halse Rogers > > This is the least-bad behaviour. It means that we signal the > vblank event before it actually happens, but since we're disabling > vblanks there's no guarantee that it wi

[PATCH 1/3] drm: Send pending vblank events before disabling vblank.

2011-04-28 Thread Jesse Barnes
On Wed, 27 Apr 2011 16:10:57 +1000 christopher.halse.rogers at canonical.com wrote: > From: Christopher James Halse Rogers canonical.com> > > This is the least-bad behaviour. It means that we signal the > vblank event before it actually happens, but since we're disabling > vblanks there's no gu

Re: [PATCH 1/3] drm: Send pending vblank events before disabling vblank.

2011-04-28 Thread Christopher James Halse Rogers
On Wed, 2011-04-27 at 11:08 +0200, Michel Dänzer wrote: > On Mit, 2011-04-27 at 18:58 +1000, Christopher James Halse Rogers > wrote: > > On Wed, 2011-04-27 at 10:32 +0200, Michel Dänzer wrote: > > > On Mit, 2011-04-27 at 16:10 +1000, christopher.halse.rog...@canonical.com > > > wrote: > > > > Fro

[PATCH 1/3] drm: Send pending vblank events before disabling vblank.

2011-04-27 Thread Christopher James Halse Rogers
On Wed, 2011-04-27 at 11:08 +0200, Michel D?nzer wrote: > On Mit, 2011-04-27 at 18:58 +1000, Christopher James Halse Rogers > wrote: > > On Wed, 2011-04-27 at 10:32 +0200, Michel D?nzer wrote: > > > On Mit, 2011-04-27 at 16:10 +1000, christopher.halse.rogers at > > > canonical.com wrote: > > > >

[PATCH 1/3] drm: Send pending vblank events before disabling vblank.

2011-04-27 Thread Christopher James Halse Rogers
On Wed, 2011-04-27 at 10:32 +0200, Michel D?nzer wrote: > On Mit, 2011-04-27 at 16:10 +1000, christopher.halse.rogers at canonical.com > wrote: > > From: Christopher James Halse Rogers > canonical.com> > > > > This is the least-bad behaviour. It means that we signal the > > vblank event before

[PATCH 1/3] drm: Send pending vblank events before disabling vblank.

2011-04-27 Thread christopher.halse.rog...@canonical.com
From: Christopher James Halse Rogers This is the least-bad behaviour. It means that we signal the vblank event before it actually happens, but since we're disabling vblanks there's no guarantee that it will *ever* happen otherwise. This prevents GL applications which use WaitMSC from hanging in

[PATCH 1/3] drm: Send pending vblank events before disabling vblank.

2011-04-27 Thread Michel Dänzer
On Mit, 2011-04-27 at 18:58 +1000, Christopher James Halse Rogers wrote: > On Wed, 2011-04-27 at 10:32 +0200, Michel D?nzer wrote: > > On Mit, 2011-04-27 at 16:10 +1000, christopher.halse.rogers at > > canonical.com wrote: > > > From: Christopher James Halse Rogers > > canonical.com> > > > > >

[PATCH 1/3] drm: Send pending vblank events before disabling vblank.

2011-04-27 Thread Michel Dänzer
On Mit, 2011-04-27 at 16:10 +1000, christopher.halse.rogers at canonical.com wrote: > From: Christopher James Halse Rogers canonical.com> > > This is the least-bad behaviour. It means that we signal the > vblank event before it actually happens, but since we're disabling > vblanks there's no gu

Re: [PATCH 1/3] drm: Send pending vblank events before disabling vblank.

2011-04-27 Thread Christopher James Halse Rogers
On Wed, 2011-04-27 at 11:08 +0200, Michel Dänzer wrote: > On Mit, 2011-04-27 at 18:58 +1000, Christopher James Halse Rogers > wrote: > > On Wed, 2011-04-27 at 10:32 +0200, Michel Dänzer wrote: > > > On Mit, 2011-04-27 at 16:10 +1000, christopher.halse.rog...@canonical.com > > > wrote: > > > > Fro

Re: [PATCH 1/3] drm: Send pending vblank events before disabling vblank.

2011-04-27 Thread Michel Dänzer
On Mit, 2011-04-27 at 18:58 +1000, Christopher James Halse Rogers wrote: > On Wed, 2011-04-27 at 10:32 +0200, Michel Dänzer wrote: > > On Mit, 2011-04-27 at 16:10 +1000, christopher.halse.rog...@canonical.com > > wrote: > > > From: Christopher James Halse Rogers > > > > > > > > > This is the l

Re: [PATCH 1/3] drm: Send pending vblank events before disabling vblank.

2011-04-27 Thread Christopher James Halse Rogers
On Wed, 2011-04-27 at 10:32 +0200, Michel Dänzer wrote: > On Mit, 2011-04-27 at 16:10 +1000, christopher.halse.rog...@canonical.com > wrote: > > From: Christopher James Halse Rogers > > > > > > This is the least-bad behaviour. It means that we signal the > > vblank event before it actually hap

Re: [PATCH 1/3] drm: Send pending vblank events before disabling vblank.

2011-04-27 Thread Michel Dänzer
On Mit, 2011-04-27 at 16:10 +1000, christopher.halse.rog...@canonical.com wrote: > From: Christopher James Halse Rogers > > This is the least-bad behaviour. It means that we signal the > vblank event before it actually happens, but since we're disabling > vblanks there's no guarantee that it wil

[PATCH 1/3] drm: Send pending vblank events before disabling vblank.

2011-04-26 Thread christopher . halse . rogers
From: Christopher James Halse Rogers This is the least-bad behaviour. It means that we signal the vblank event before it actually happens, but since we're disabling vblanks there's no guarantee that it will *ever* happen otherwise. This prevents GL applications which use WaitMSC from hanging in