Re: [PATCH 1/4] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain

2017-02-07 Thread Mark yao
On 2017年02月07日 14:53, Tomasz Figa wrote: Hi Mark, Thanks for reviving this series and sorry for not taking care of it myself. Please see some comments inline. Hi Tomasz Thanks for review, I will add the patches you mentioned into v2 version. On Tue, Feb 7, 2017 at 3:09 PM, Mark Yao wrot

Re: [PATCH 1/4] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain

2017-02-06 Thread Tomasz Figa
Hi Mark, Thanks for reviving this series and sorry for not taking care of it myself. Please see some comments inline. On Tue, Feb 7, 2017 at 3:09 PM, Mark Yao wrote: > From: Tomasz Figa > > The API is not suitable for subsystems consisting of multiple devices > and requires severe hacks to use

[PATCH 1/4] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain

2017-02-06 Thread Mark Yao
From: Tomasz Figa The API is not suitable for subsystems consisting of multiple devices and requires severe hacks to use it. To mitigate this, this patch implements allocation and address space management locally by using helpers provided by DRM framework, like other DRM drivers do, e.g. Tegra.