[Intel-gfx] [PATCH 1/7] drm/i915: Move common PCH_PP_CONTROL setup to ironlake_get_pp_control

2011-11-02 Thread Keith Packard
On Wed, 2 Nov 2011 09:02:55 -0700, Jesse Barnes wrote: > Can't we just set UNLOCK_REGS at load time and have asserts sprinkled > here and there? I think we'd need it at resume time as well; it seemed easier to just set it every time we touch the register. -- keith.packard at intel.com

[Intel-gfx] [PATCH 1/7] drm/i915: Move common PCH_PP_CONTROL setup to ironlake_get_pp_control

2011-11-02 Thread Jesse Barnes
On Tue, 1 Nov 2011 23:20:24 -0700 Keith Packard wrote: > Every usage of PCH_PP_CONTROL sets the PANEL_UNLOCK_REGS value to > ensure that writes will be respected, move this to a common function > to make the driver cleaner. > > No functional changes. > > Signed-off-by: Keith Packard > --- >

[PATCH 1/7] drm/i915: Move common PCH_PP_CONTROL setup to ironlake_get_pp_control

2011-11-02 Thread Keith Packard
Every usage of PCH_PP_CONTROL sets the PANEL_UNLOCK_REGS value to ensure that writes will be respected, move this to a common function to make the driver cleaner. No functional changes. Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/intel_dp.c | 37

[PATCH 1/7] drm/i915: Move common PCH_PP_CONTROL setup to ironlake_get_pp_control

2011-11-02 Thread Keith Packard
Every usage of PCH_PP_CONTROL sets the PANEL_UNLOCK_REGS value to ensure that writes will be respected, move this to a common function to make the driver cleaner. No functional changes. Signed-off-by: Keith Packard kei...@keithp.com --- drivers/gpu/drm/i915/intel_dp.c | 37

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Move common PCH_PP_CONTROL setup to ironlake_get_pp_control

2011-11-02 Thread Jesse Barnes
On Tue, 1 Nov 2011 23:20:24 -0700 Keith Packard kei...@keithp.com wrote: Every usage of PCH_PP_CONTROL sets the PANEL_UNLOCK_REGS value to ensure that writes will be respected, move this to a common function to make the driver cleaner. No functional changes. Signed-off-by: Keith Packard

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Move common PCH_PP_CONTROL setup to ironlake_get_pp_control

2011-11-02 Thread Keith Packard
On Wed, 2 Nov 2011 09:02:55 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: Can't we just set UNLOCK_REGS at load time and have asserts sprinkled here and there? I think we'd need it at resume time as well; it seemed easier to just set it every time we touch the register. --