Re: [PATCH 1/7] drm/leases: Drop object_id validation for negative ids

2019-03-29 Thread Daniel Vetter
On Fri, Mar 29, 2019 at 02:46:55PM +1000, Dave Airlie wrote: > commit 2e1c9b2867656ff9a469d23e1dfe90cf77ec0c72 > Author: Tejun Heo > Date: Fri Mar 8 12:43:30 2013 -0800 > > idr: remove WARN_ON_ONCE() on negative IDs > > We used to WARN_ON if we hit a negative id, it appears we don't > anym

Re: [PATCH 1/7] drm/leases: Drop object_id validation for negative ids

2019-03-28 Thread Dave Airlie
commit 2e1c9b2867656ff9a469d23e1dfe90cf77ec0c72 Author: Tejun Heo Date: Fri Mar 8 12:43:30 2013 -0800 idr: remove WARN_ON_ONCE() on negative IDs We used to WARN_ON if we hit a negative id, it appears we don't anymore, so just update the commit msg to reflect that info on where the code cam

Re: [PATCH 1/7] drm/leases: Drop object_id validation for negative ids

2019-03-14 Thread Boris Brezillon
On Thu, 28 Feb 2019 15:49:04 +0100 Daniel Vetter wrote: > Not exactly sure what's the aim here, but the canonical nil object has > id == 0, we don't use negative object ids for anything. Plus all > object_id are valided by the object_idr, there's nothing we need to do > on top of that ENOENT chec

[PATCH 1/7] drm/leases: Drop object_id validation for negative ids

2019-02-28 Thread Daniel Vetter
Not exactly sure what's the aim here, but the canonical nil object has id == 0, we don't use negative object ids for anything. Plus all object_id are valided by the object_idr, there's nothing we need to do on top of that ENOENT check a bit further down. Spotted while typing exhaustive igt coverag

[PATCH 1/7] drm/leases: Drop object_id validation for negative ids

2019-02-28 Thread Daniel Vetter
Not exactly sure what's the aim here, but the canonical nil object has id == 0, we don't use negative object ids for anything. Plus all object_id are valided by the object_idr, there's nothing we need to do on top of that ENOENT check a bit further down. Spotted while typing exhaustive igt coverag