Re: [PATCH 2/2] backlight: rt4831: Add the property parsing for ocp level selection

2022-05-27 Thread Daniel Thompson
On Fri, May 27, 2022 at 10:24:42AM +0800, ChiYuan Huang wrote: > Daniel Thompson 於 2022年5月26日 週四 下午6:05寫道: > > > > On Thu, May 26, 2022 at 11:16:35AM +0800, cy_huang wrote: > > > From: ChiYuan Huang > > > > > > Add the property parsing for ocp level selection. > > > > Isn't this just restating

Re: [PATCH 2/2] backlight: rt4831: Add the property parsing for ocp level selection

2022-05-26 Thread ChiYuan Huang
Daniel Thompson 於 2022年5月26日 週四 下午6:05寫道: > > On Thu, May 26, 2022 at 11:16:35AM +0800, cy_huang wrote: > > From: ChiYuan Huang > > > > Add the property parsing for ocp level selection. > > Isn't this just restating the Subject: line? > Ah, that's my fault. I didn't state too much in the patch

Re: [PATCH 2/2] backlight: rt4831: Add the property parsing for ocp level selection

2022-05-26 Thread Daniel Thompson
On Thu, May 26, 2022 at 11:16:35AM +0800, cy_huang wrote: > From: ChiYuan Huang > > Add the property parsing for ocp level selection. Isn't this just restating the Subject: line? It would be better to provide information useful to the reviewer here. Something like: "Currently this driver

[PATCH 2/2] backlight: rt4831: Add the property parsing for ocp level selection

2022-05-25 Thread cy_huang
From: ChiYuan Huang Add the property parsing for ocp level selection. Reported-by: Lucas Tsai Signed-off-by: ChiYuan Huang --- drivers/video/backlight/rt4831-backlight.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/video/backlight/rt4831-backlight.c