From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sat, 19 Dec 2020 18:18:59 +0100

Adjust a jump target so that a bit of exception handling can be better
reused at the end of this function.

Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
---
 drivers/gpu/drm/amd/display/dc/core/dc.c | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c 
b/drivers/gpu/drm/amd/display/dc/core/dc.c
index e35fbfcb4d0e..64344c054c93 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -968,15 +968,11 @@ struct dc *dc_create(const struct dc_init_data 
*init_params)
                return NULL;

        if (init_params->dce_environment == DCE_ENV_VIRTUAL_HW) {
-               if (false == dc_construct_ctx(dc, init_params)) {
-                       dc_destruct(dc);
-                       goto construct_fail;
-               }
+               if (!dc_construct_ctx(dc, init_params))
+                       goto destruct_dc;
        } else {
-               if (false == dc_construct(dc, init_params)) {
-                       dc_destruct(dc);
-                       goto construct_fail;
-               }
+               if (!dc_construct(dc, init_params))
+                       goto destruct_dc;

                full_pipe_count = dc->res_pool->pipe_count;
                if (dc->res_pool->underlay_pipe_index != NO_UNDERLAY_PIPE)
@@ -1007,7 +1003,8 @@ struct dc *dc_create(const struct dc_init_data 
*init_params)

        return dc;

-construct_fail:
+destruct_dc:
+       dc_destruct(dc);
        kfree(dc);
        return NULL;
 }
--
2.29.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to