Re: [PATCH 2/2] drm/amdgpu: Dirty cleared blocks on allocation

2025-05-28 Thread Christian König
On 5/28/25 14:39, Michel Dänzer wrote: > On 2025-05-28 14:14, Paneer Selvam, Arunpravin wrote: >> On 5/28/2025 2:59 PM, Natalie Vock wrote: >>> On 5/28/25 09:07, Christian König wrote: But the problem rather seems to be that we sometimes don't clear the buffers on release for some r

Re: [PATCH 2/2] drm/amdgpu: Dirty cleared blocks on allocation

2025-05-28 Thread Michel Dänzer
On 2025-05-28 14:14, Paneer Selvam, Arunpravin wrote: > On 5/28/2025 2:59 PM, Natalie Vock wrote: >> On 5/28/25 09:07, Christian König wrote: >>> >>> But the problem rather seems to be that we sometimes don't clear the >>> buffers on release for some reason, but still set it as cleared. >> >> Yes

Re: [PATCH 2/2] drm/amdgpu: Dirty cleared blocks on allocation

2025-05-28 Thread Paneer Selvam, Arunpravin
On 5/28/2025 2:59 PM, Natalie Vock wrote: Hi, On 5/28/25 09:07, Christian König wrote: On 5/27/25 21:43, Natalie Vock wrote: If we hand out cleared blocks to users, they are expected to write at least some non-zero values somewhere. If we keep the CLEAR bit set on the block, amdgpu_fill_b

Re: [PATCH 2/2] drm/amdgpu: Dirty cleared blocks on allocation

2025-05-28 Thread Christian König
On 5/28/25 11:29, Natalie Vock wrote: > Hi, > > On 5/28/25 09:07, Christian König wrote: >> On 5/27/25 21:43, Natalie Vock wrote: >>> If we hand out cleared blocks to users, they are expected to write >>> at least some non-zero values somewhere. If we keep the CLEAR bit set on >>> the block, amdgp

Re: [PATCH 2/2] drm/amdgpu: Dirty cleared blocks on allocation

2025-05-28 Thread Natalie Vock
Hi, On 5/28/25 09:07, Christian König wrote: On 5/27/25 21:43, Natalie Vock wrote: If we hand out cleared blocks to users, they are expected to write at least some non-zero values somewhere. If we keep the CLEAR bit set on the block, amdgpu_fill_buffer will assume there is nothing to do and inc

Re: [PATCH 2/2] drm/amdgpu: Dirty cleared blocks on allocation

2025-05-28 Thread Christian König
On 5/27/25 21:43, Natalie Vock wrote: > If we hand out cleared blocks to users, they are expected to write > at least some non-zero values somewhere. If we keep the CLEAR bit set on > the block, amdgpu_fill_buffer will assume there is nothing to do and > incorrectly skip clearing the block. Ultimat

[PATCH 2/2] drm/amdgpu: Dirty cleared blocks on allocation

2025-05-27 Thread Natalie Vock
If we hand out cleared blocks to users, they are expected to write at least some non-zero values somewhere. If we keep the CLEAR bit set on the block, amdgpu_fill_buffer will assume there is nothing to do and incorrectly skip clearing the block. Ultimately, the (still dirty) block will be reused as