[Intel-gfx] [PATCH 2/2] drm/i915: Select DP BPC at mode set, rather than mode validate

2012-01-25 Thread Daniel Vetter
On Wed, Jan 25, 2012 at 08:16:26AM -0800, Keith Packard wrote: > The DP configuration must match the pipe configuration, and until mode > set we don't know what BPC will be used. Delay all decisions about BPC > until mode set, computing the target BPC in both intel_dp_mode_fixup > and either i9xx_c

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Select DP BPC at mode set, rather than mode validate

2012-01-25 Thread Keith Packard
On Wed, 25 Jan 2012 23:11:00 +0100, Daniel Vetter wrote: > I'm a bit unhappy how generic code in intel_display.c calls function out > of intel_dp.c. And choose_pipe_bpp_dither already has special cases for > quite a few other encoders ... Could we add an ->adjust_bpc function to > intel_encoder t

[Intel-gfx] [PATCH 2/2] drm/i915: Select DP BPC at mode set, rather than mode validate

2012-01-25 Thread Keith Packard
On Wed, 25 Jan 2012 23:11:00 +0100, Daniel Vetter wrote: > I'm a bit unhappy how generic code in intel_display.c calls function out > of intel_dp.c. And choose_pipe_bpp_dither already has special cases for > quite a few other encoders ... Could we add an ->adjust_bpc function to > intel_encoder t

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Select DP BPC at mode set, rather than mode validate

2012-01-25 Thread Daniel Vetter
On Wed, Jan 25, 2012 at 08:16:26AM -0800, Keith Packard wrote: > The DP configuration must match the pipe configuration, and until mode > set we don't know what BPC will be used. Delay all decisions about BPC > until mode set, computing the target BPC in both intel_dp_mode_fixup > and either i9xx_c

[PATCH 2/2] drm/i915: Select DP BPC at mode set, rather than mode validate

2012-01-25 Thread Keith Packard
The DP configuration must match the pipe configuration, and until mode set we don't know what BPC will be used. Delay all decisions about BPC until mode set, computing the target BPC in both intel_dp_mode_fixup and either i9xx_crtc_mode_set or ironlake_crtc_mode_set. It might be slightly better to

[PATCH 2/2] drm/i915: Select DP BPC at mode set, rather than mode validate

2012-01-25 Thread Keith Packard
The DP configuration must match the pipe configuration, and until mode set we don't know what BPC will be used. Delay all decisions about BPC until mode set, computing the target BPC in both intel_dp_mode_fixup and either i9xx_crtc_mode_set or ironlake_crtc_mode_set. It might be slightly better to