Re: [PATCH 2/2] drm/sched: Rename to drm_sched_wakeup_if_canqueue()

2023-05-17 Thread Luben Tuikov
Ignore this series--I'll repost without the duplication. Regards, Luben On 2023-05-17 19:08, Luben Tuikov wrote: > Rename drm_sched_wakeup() to drm_sched_wakeup_if_canqueue() since the former > is misleading, as it wakes up the GPU scheduler _only if_ more jobs can be > queued to the underlying

[PATCH 2/2] drm/sched: Rename to drm_sched_wakeup_if_canqueue()

2023-05-17 Thread Luben Tuikov
Rename drm_sched_wakeup() to drm_sched_wakeup_if_canqueue() since the former is misleading, as it wakes up the GPU scheduler _only if_ more jobs can be queued to the underlying hardware. This distinction is important to make, since the wake conditional in the GPU scheduler thread wakes up when

Re: [PATCH 2/2] drm/sched: Rename to drm_sched_wakeup_if_canqueue()

2023-05-17 Thread Luben Tuikov
On 2023-05-17 16:43, Alex Deucher wrote: > On Wed, May 17, 2023 at 3:04 PM Luben Tuikov wrote: >> >> Rename drm_sched_wakeup() to drm_sched_wakeup_if_canqueue() since the former > > I think drm_sched_wakeup_if_can_queue() looks cleaner. Yeah, I can change it to this--I was concerned of too many

Re: [PATCH 2/2] drm/sched: Rename to drm_sched_wakeup_if_canqueue()

2023-05-17 Thread Alex Deucher
On Wed, May 17, 2023 at 3:04 PM Luben Tuikov wrote: > > Rename drm_sched_wakeup() to drm_sched_wakeup_if_canqueue() since the former I think drm_sched_wakeup_if_can_queue() looks cleaner. Alex > is misleading, as it wakes up the GPU scheduler _only if_ more jobs can be > queued to the

[PATCH 2/2] drm/sched: Rename to drm_sched_wakeup_if_canqueue()

2023-05-17 Thread Luben Tuikov
Rename drm_sched_wakeup() to drm_sched_wakeup_if_canqueue() since the former is misleading, as it wakes up the GPU scheduler _only if_ more jobs can be queued to the underlying hardware. This distinction is important to make, since the wake conditional in the GPU scheduler thread wakes up when