Re: [PATCH 2/2] phy: Add driver for mixel dphy

2019-02-01 Thread Guido Günther
Hi Sam, On Fri, Jan 25, 2019 at 05:53:55PM +0100, Sam Ravnborg wrote: [..snip..] > > +struct mixel_dphy_cfg { > > + u32 cm; > > + u32 cn; > > + u32 co; > > + unsigned long hs_clk_rate; > > + u8 mc_prg_hs_prepare; > > + u8 m_prg_hs_prepare; > > + u8 mc_prg_hs_zero; > > + u8 m_prg_hs_

Re: [PATCH 2/2] phy: Add driver for mixel dphy

2019-01-30 Thread Guido Günther
Hi, On Mon, Jan 28, 2019 at 01:10:45PM -0200, Fabio Estevam wrote: > Hi Guido, > > On Fri, Jan 25, 2019 at 8:15 AM Guido Günther wrote: > > > +config PHY_MIXEL_MIPI_DPHY > > + bool > > + depends on OF > > + select GENERIC_PHY > > + select GENERIC_PHY_MIPI_DPHY > > +

Re: [PATCH 2/2] phy: Add driver for mixel dphy

2019-01-28 Thread Fabio Estevam
Hi Guido, On Fri, Jan 25, 2019 at 8:15 AM Guido Günther wrote: > +config PHY_MIXEL_MIPI_DPHY > + bool > + depends on OF > + select GENERIC_PHY > + select GENERIC_PHY_MIPI_DPHY > + default ARCH_MXC && ARM64 No need to force this selection for all i.MX8M boards, as n

Re: [PATCH 2/2] phy: Add driver for mixel dphy

2019-01-25 Thread Sam Ravnborg
Hi Guido. Patch looks good but a few comments below. Sam On Fri, Jan 25, 2019 at 11:14:46AM +0100, Guido Günther wrote: > This adds support for the Mixel DPHY as found on i.MX8 CPUs but since > this is an IP core it will likely be found on others in the future. So > instead of adding thi

[PATCH 2/2] phy: Add driver for mixel dphy

2019-01-25 Thread Guido Günther
This adds support for the Mixel DPHY as found on i.MX8 CPUs but since this is an IP core it will likely be found on others in the future. So instead of adding this to the nwl host driver make it a generic PHY driver. The driver supports the i.MX8MQ. Support for i.MX8QM and i.MX8QXP can be added on