Re: [PATCH 2/2 v6] drm/panel: Add driver for Sony ACX424AKP panel

2020-01-03 Thread Linus Walleij
On Wed, Nov 20, 2019 at 12:53 PM Stephan Gerhold wrote: > On Thu, Nov 14, 2019 at 02:15:25PM +0100, Linus Walleij wrote: > > + /* Calculate the PWM duty cycle in n/256's */ > > + pwm_ratio = max(((duty_ns * 256) / period_ns) - 1, 1); > > + pwm_div = max(1, > > +

Re: [PATCH 2/2 v6] drm/panel: Add driver for Sony ACX424AKP panel

2019-12-15 Thread Sam Ravnborg
Hi Linus. Thanks for another panel driver. A mixed set of review comments in the following. Sam On Thu, Nov 14, 2019 at 02:15:25PM +0100, Linus Walleij wrote: > The Sony ACX424AKP is a command/videomode DSI panel for > mobile devices. It is used on the ST-Ericsson HREF520 > reference

Re: [PATCH 2/2 v6] drm/panel: Add driver for Sony ACX424AKP panel

2019-11-20 Thread Stephan Gerhold
On Thu, Nov 14, 2019 at 02:15:25PM +0100, Linus Walleij wrote: > The Sony ACX424AKP is a command/videomode DSI panel for > mobile devices. It is used on the ST-Ericsson HREF520 > reference design. We support video mode by default, but > it is possible to switch the panel into command mode > by

[PATCH 2/2 v6] drm/panel: Add driver for Sony ACX424AKP panel

2019-11-14 Thread Linus Walleij
The Sony ACX424AKP is a command/videomode DSI panel for mobile devices. It is used on the ST-Ericsson HREF520 reference design. We support video mode by default, but it is possible to switch the panel into command mode by using the bool property "dsi-command-mode". Cc: Stephan Gerhold