Re: [PATCH 2/3] drm: qxl: Open code probing sequence for qxl

2017-01-17 Thread Gabriel Krisman Bertazi
Gustavo Padovan writes: > I'm not confortable with exposing minor->type here and making qxl > the first driver to use it outside of drm core. Don't we have any other > way. > > I see that inside qxl_debugfs_add_files() we have a check for already > registered files.

Re: [PATCH 2/3] drm: qxl: Open code probing sequence for qxl

2017-01-16 Thread Gustavo Padovan
Hi Gabriel, 2017-01-12 Gabriel Krisman Bertazi : > This avoids using the deprecated drm_get_pci_dev() and load() hook > interfaces in the qxl driver. > > The only tricky part is to ensure TTM debugfs initialization > happens after the debugfs root node is created, which

[PATCH 2/3] drm: qxl: Open code probing sequence for qxl

2017-01-12 Thread Gabriel Krisman Bertazi
This avoids using the deprecated drm_get_pci_dev() and load() hook interfaces in the qxl driver. The only tricky part is to ensure TTM debugfs initialization happens after the debugfs root node is created, which is done by moving that code into the debufs_init() hook. Since the hook is called 3