[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-11-08 Thread Daniel Vetter
On Mon, Oct 31, 2016 at 12:09:23AM +, Russell King - ARM Linux wrote: > On Mon, Oct 24, 2016 at 08:53:04AM +0200, Daniel Vetter wrote: > > On Mon, Oct 24, 2016 at 11:58:00AM +0530, Archit Taneja wrote: > > > On 10/22/2016 03:25 PM, Russell King - ARM Linux wrote: > > > > Looking at

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-31 Thread Russell King - ARM Linux
On Mon, Oct 24, 2016 at 08:53:04AM +0200, Daniel Vetter wrote: > On Mon, Oct 24, 2016 at 11:58:00AM +0530, Archit Taneja wrote: > > On 10/22/2016 03:25 PM, Russell King - ARM Linux wrote: > > > Looking at drm_bridge_disable() and drm_bridge_enable(), the control > > > model appears to be: > > > >

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-30 Thread Russell King - ARM Linux
On Mon, Oct 24, 2016 at 10:39:27AM +0530, Archit Taneja wrote: > Sorry about that. I'll post out a proper patch for this once we resolve > the drm_bridge shortcomings you've mentioned. I can create one if you > want to try it now. As said elsewhere, I've been away, so I haven't had a chance to

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-24 Thread Brian Starkey
Hi Russell, On Sat, Oct 22, 2016 at 02:40:22PM +0100, Russell King - ARM Linux wrote: >On Wed, Oct 19, 2016 at 10:46:48AM +0100, Brian Starkey wrote: >> Hi Jyri, >> >> I believe this will break mali-dp and hdlcd, unless something changed >> while I wasn't looking. Please see this previous thread

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-24 Thread Archit Taneja
On 10/22/2016 03:25 PM, Russell King - ARM Linux wrote: > On Fri, Oct 21, 2016 at 09:04:39PM +0200, Jean-Francois Moine wrote: >> On Wed, Oct 19, 2016 at 12:19:30PM +0300, Laurent Pinchart wrote: >> (sorry, I lost your original mail) >> DRM bridges indeed don't create encoders. That

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-24 Thread Archit Taneja
On 10/21/2016 11:39 PM, Russell King - ARM Linux wrote: > On Thu, Oct 20, 2016 at 04:56:44PM +0530, Archit Taneja wrote: >> 3) Rough conversion to bridge: > > So I thought I might give this a try, and see what's needed to complete > the patch, but... > > I thought we'd got past the dark ages of

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-24 Thread Archit Taneja
On 10/22/2016 12:13 AM, Russell King - ARM Linux wrote: > On Thu, Oct 20, 2016 at 04:56:44PM +0530, Archit Taneja wrote: >> >> >> On 10/20/2016 02:45 PM, Russell King - ARM Linux wrote: >>> On Thu, Oct 20, 2016 at 02:38:25PM +0530, Archit Taneja wrote: On 10/20/2016 01:50 PM,

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-24 Thread Daniel Vetter
On Mon, Oct 24, 2016 at 11:58:00AM +0530, Archit Taneja wrote: > On 10/22/2016 03:25 PM, Russell King - ARM Linux wrote: > > On Fri, Oct 21, 2016 at 09:04:39PM +0200, Jean-Francois Moine wrote: > > > > > > > On Wed, Oct 19, 2016 at 12:19:30PM +0300, Laurent Pinchart wrote: > > > (sorry, I lost

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-22 Thread Russell King - ARM Linux
On Wed, Oct 19, 2016 at 10:46:48AM +0100, Brian Starkey wrote: > Hi Jyri, > > I believe this will break mali-dp and hdlcd, unless something changed > while I wasn't looking. Please see this previous thread where I did > the same thing and then had to have it reverted: [1] > > Before removing

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-22 Thread Laurent Pinchart
Hi Jean-François, On Friday 21 Oct 2016 19:28:47 Jean-Francois Moine wrote: > On Thu, 20 Oct 2016 16:56:44 +0530 Archit Taneja wrote: > >> Please show _technically_ how this would work. I want to see code or > >> pseudo-code illustrating how a "foreign" DRM encoder could be used with > >>

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-22 Thread Russell King - ARM Linux
On Fri, Oct 21, 2016 at 09:04:39PM +0200, Jean-Francois Moine wrote: > On Wed, Oct 19, 2016 at 12:19:30PM +0300, Laurent Pinchart wrote: > (sorry, I lost your original mail) > > >>> DRM bridges indeed don't create encoders. That task is left to the > > >>> display > > >>> driver. The

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-21 Thread Jean-Francois Moine
On Wed, Oct 19, 2016 at 12:19:30PM +0300, Laurent Pinchart wrote: (sorry, I lost your original mail) > >>> DRM bridges indeed don't create encoders. That task is left to the display > >>> driver. The reason is the same as above: bridges can be chained (including > >>> with an internal

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-21 Thread Russell King - ARM Linux
On Thu, Oct 20, 2016 at 04:56:44PM +0530, Archit Taneja wrote: > > > On 10/20/2016 02:45 PM, Russell King - ARM Linux wrote: > >On Thu, Oct 20, 2016 at 02:38:25PM +0530, Archit Taneja wrote: > >> > >> > >>On 10/20/2016 01:50 PM, Laurent Pinchart wrote: > >>>Hi Russell, > >>> > >>>On Wednesday 19

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-21 Thread Jean-Francois Moine
On Thu, 20 Oct 2016 16:56:44 +0530 Archit Taneja wrote: > > Please show _technically_ how this would work. I want to see code or > > pseudo-code illustrating how a "foreign" DRM encoder could be used with > > either dw-hdmi or tda998x, because right now I can't see any way that > > could work.

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-21 Thread Russell King - ARM Linux
On Thu, Oct 20, 2016 at 04:56:44PM +0530, Archit Taneja wrote: > 3) Rough conversion to bridge: So I thought I might give this a try, and see what's needed to complete the patch, but... I thought we'd got past the dark ages of email clients screwing up patches, but it seems not. This patch is

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-20 Thread Archit Taneja
On 10/20/2016 02:45 PM, Russell King - ARM Linux wrote: > On Thu, Oct 20, 2016 at 02:38:25PM +0530, Archit Taneja wrote: >> >> >> On 10/20/2016 01:50 PM, Laurent Pinchart wrote: >>> Hi Russell, >>> >>> On Wednesday 19 Oct 2016 10:35:21 Russell King - ARM Linux wrote: On Wed, Oct 19, 2016 at

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-20 Thread Archit Taneja
On 10/20/2016 01:50 PM, Laurent Pinchart wrote: > Hi Russell, > > On Wednesday 19 Oct 2016 10:35:21 Russell King - ARM Linux wrote: >> On Wed, Oct 19, 2016 at 12:19:30PM +0300, Laurent Pinchart wrote: >>> On Wednesday 19 Oct 2016 10:11:22 Russell King - ARM Linux wrote: In any case, I don't

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-20 Thread Laurent Pinchart
Hi Russell, On Wednesday 19 Oct 2016 10:35:21 Russell King - ARM Linux wrote: > On Wed, Oct 19, 2016 at 12:19:30PM +0300, Laurent Pinchart wrote: > > On Wednesday 19 Oct 2016 10:11:22 Russell King - ARM Linux wrote: > >> In any case, I don't agree with converting it to a DRM bridge - that > >>

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-20 Thread Russell King - ARM Linux
On Thu, Oct 20, 2016 at 02:38:25PM +0530, Archit Taneja wrote: > > > On 10/20/2016 01:50 PM, Laurent Pinchart wrote: > >Hi Russell, > > > >On Wednesday 19 Oct 2016 10:35:21 Russell King - ARM Linux wrote: > >>On Wed, Oct 19, 2016 at 12:19:30PM +0300, Laurent Pinchart wrote: > >>>On Wednesday 19

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-20 Thread Russell King - ARM Linux
On Thu, Oct 20, 2016 at 11:20:05AM +0300, Laurent Pinchart wrote: > Hi Russell, > > On Wednesday 19 Oct 2016 10:35:21 Russell King - ARM Linux wrote: > > Moreover, as I've already said, converting tda998x to a DRM bridge > > will not get rid of the encoder/connector part, because it _is_ a > >

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-19 Thread Laurent Pinchart
Hi Russell, On Wednesday 19 Oct 2016 10:11:22 Russell King - ARM Linux wrote: > On Wed, Oct 19, 2016 at 11:52:15AM +0300, Laurent Pinchart wrote: > > On Wednesday 19 Oct 2016 09:16:30 Russell King - ARM Linux wrote: > >> On Wed, Oct 19, 2016 at 10:54:06AM +0300, Laurent Pinchart wrote: > >>> On

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-19 Thread Laurent Pinchart
Hi Russell, On Wednesday 19 Oct 2016 09:16:30 Russell King - ARM Linux wrote: > On Wed, Oct 19, 2016 at 10:54:06AM +0300, Laurent Pinchart wrote: > > On Wednesday 19 Oct 2016 00:33:54 Jyri Sarha wrote: > >> Remove obsolete drm_connector_register() call from tda998x_bind(). All > >> connectors are

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-19 Thread Laurent Pinchart
Hi Jyri, Thank you for the patch. On Wednesday 19 Oct 2016 00:33:54 Jyri Sarha wrote: > Remove obsolete drm_connector_register() call from tda998x_bind(). All > connectors are registered when drm_dev_register() is called by the > master drm_device driver. > > Signed-off-by: Jyri Sarha

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-19 Thread Brian Starkey
Hi Jyri, I believe this will break mali-dp and hdlcd, unless something changed while I wasn't looking. Please see this previous thread where I did the same thing and then had to have it reverted: [1] Before removing this, we need to refactor (at least) mali-dp and hdlcd to move

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-19 Thread Russell King - ARM Linux
On Wed, Oct 19, 2016 at 12:19:30PM +0300, Laurent Pinchart wrote: > Hi Russell, > > On Wednesday 19 Oct 2016 10:11:22 Russell King - ARM Linux wrote: > > In any case, I don't agree with converting it to a DRM bridge - that will > > mean that we have to split the driver into two pieces, the bridge

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-19 Thread Russell King - ARM Linux
On Wed, Oct 19, 2016 at 11:52:15AM +0300, Laurent Pinchart wrote: > Hi Russell, > > On Wednesday 19 Oct 2016 09:16:30 Russell King - ARM Linux wrote: > > On Wed, Oct 19, 2016 at 10:54:06AM +0300, Laurent Pinchart wrote: > > > On Wednesday 19 Oct 2016 00:33:54 Jyri Sarha wrote: > > >> Remove

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-19 Thread Russell King - ARM Linux
On Wed, Oct 19, 2016 at 10:54:06AM +0300, Laurent Pinchart wrote: > Hi Jyri, > > Thank you for the patch. > > On Wednesday 19 Oct 2016 00:33:54 Jyri Sarha wrote: > > Remove obsolete drm_connector_register() call from tda998x_bind(). All > > connectors are registered when drm_dev_register() is

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-19 Thread Jyri Sarha
Remove obsolete drm_connector_register() call from tda998x_bind(). All connectors are registered when drm_dev_register() is called by the master drm_device driver. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/i2c/tda998x_drv.c | 6 -- 1 file changed, 6 deletions(-) diff --git