Re: [PATCH 2/4] regulator: Introduce Qualcomm REFGEN regulator driver

2023-06-29 Thread Konrad Dybcio
On 29.06.2023 10:43, Konrad Dybcio wrote: > On 28.06.2023 21:28, Mark Brown wrote: >> On Wed, Jun 28, 2023 at 06:29:46PM +0200, Konrad Dybcio wrote: >> >>> +// SPDX-License-Identifier: GPL-2.0-only >>> +/* >>> + * Copyright (c) 2017, 2019-2020, The Linux Foundation. All rights >>> reserved. >>> +

Re: [PATCH 2/4] regulator: Introduce Qualcomm REFGEN regulator driver

2023-06-29 Thread Konrad Dybcio
On 28.06.2023 21:28, Mark Brown wrote: > On Wed, Jun 28, 2023 at 06:29:46PM +0200, Konrad Dybcio wrote: > >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * Copyright (c) 2017, 2019-2020, The Linux Foundation. All rights reserved. >> + * Copyright (c) 2023, Linaro Limited >> + */ > > Plea

Re: [PATCH 2/4] regulator: Introduce Qualcomm REFGEN regulator driver

2023-06-28 Thread kernel test robot
: 5c875096d59010cee4e00da1f9c7bdb07a025dc2 patch link: https://lore.kernel.org/r/20230628-topic-refgen-v1-2-126e59573eeb%40linaro.org patch subject: [PATCH 2/4] regulator: Introduce Qualcomm REFGEN regulator driver config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20230629/202306290533

Re: [PATCH 2/4] regulator: Introduce Qualcomm REFGEN regulator driver

2023-06-28 Thread Mark Brown
On Wed, Jun 28, 2023 at 06:29:46PM +0200, Konrad Dybcio wrote: > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2017, 2019-2020, The Linux Foundation. All rights reserved. > + * Copyright (c) 2023, Linaro Limited > + */ Please use a C++ comment for the whole thing for consist

[PATCH 2/4] regulator: Introduce Qualcomm REFGEN regulator driver

2023-06-28 Thread Konrad Dybcio
Modern Qualcomm SoCs have a REFGEN (reference voltage generator) regulator, providing reference voltage to on-chip IP, like PHYs. Add a driver to support toggling that regulator. This driver is based on the driver available in the downstream msm-5.4 kernel. It's been cleaned up and partly remade