Re: [PATCH 2/5] drm/mgag200: Integrate init function into load function

2020-05-05 Thread Sam Ravnborg
On Tue, May 05, 2020 at 11:56:46AM +0200, Thomas Zimmermann wrote: > Done to simplify initialization code before embedding the DRM device > instance in struct mga_device. And replace DRM_ERROR with drm_err And replace r with ret. I could not follow all the code re-shuffeling, but I expect it to

Re: [PATCH 2/5] drm/mgag200: Integrate init function into load function

2020-05-05 Thread Daniel Vetter
On Tue, May 05, 2020 at 11:56:46AM +0200, Thomas Zimmermann wrote: > Done to simplify initialization code before embedding the DRM device > instance in struct mga_device. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/mgag200/mgag200_main.c | 67

[PATCH 2/5] drm/mgag200: Integrate init function into load function

2020-05-05 Thread Thomas Zimmermann
Done to simplify initialization code before embedding the DRM device instance in struct mga_device. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_main.c | 67 ++ 1 file changed, 26 insertions(+), 41 deletions(-) diff --git