[PATCH 2/6] drm: add helper for printing to log or seq_file

2016-10-24 Thread Rob Clark
On Mon, Oct 17, 2016 at 1:00 PM, Sean Paul wrote: > On Fri, Oct 14, 2016 at 7:55 PM, Rob Clark wrote: >> Sometimes it is nice not to duplicate equivalent printk() and >> seq_printf() code. >> >> Signed-off-by: Rob Clark >> --- >> drivers/gpu/drm/Makefile| 3 ++- >>

[PATCH 2/6] drm: add helper for printing to log or seq_file

2016-10-17 Thread Daniel Vetter
On Mon, Oct 17, 2016 at 07:59:51AM -0400, Rob Clark wrote: > On Mon, Oct 17, 2016 at 2:38 AM, Daniel Vetter wrote: > > On Fri, Oct 14, 2016 at 07:55:49PM -0400, Rob Clark wrote: > >> Sometimes it is nice not to duplicate equivalent printk() and > >> seq_printf() code. > >> > >> Signed-off-by: Rob

[PATCH 2/6] drm: add helper for printing to log or seq_file

2016-10-17 Thread Sean Paul
On Fri, Oct 14, 2016 at 7:55 PM, Rob Clark wrote: > Sometimes it is nice not to duplicate equivalent printk() and > seq_printf() code. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/Makefile| 3 ++- > drivers/gpu/drm/drm_print.c | 54 +++ >

[PATCH 2/6] drm: add helper for printing to log or seq_file

2016-10-17 Thread Daniel Vetter
On Fri, Oct 14, 2016 at 07:55:49PM -0400, Rob Clark wrote: > Sometimes it is nice not to duplicate equivalent printk() and > seq_printf() code. > > Signed-off-by: Rob Clark Ok, maybe I should wait for coffee to kick in before commenting on patches ;-) Two bits: - kerneldoc for this pls, plus

[PATCH 2/6] drm: add helper for printing to log or seq_file

2016-10-17 Thread Rob Clark
On Mon, Oct 17, 2016 at 8:30 AM, Daniel Vetter wrote: > On Mon, Oct 17, 2016 at 07:59:51AM -0400, Rob Clark wrote: >> On Mon, Oct 17, 2016 at 2:38 AM, Daniel Vetter wrote: >> > On Fri, Oct 14, 2016 at 07:55:49PM -0400, Rob Clark wrote: >> >> Sometimes it is nice not to duplicate equivalent

[PATCH 2/6] drm: add helper for printing to log or seq_file

2016-10-17 Thread Rob Clark
On Mon, Oct 17, 2016 at 2:38 AM, Daniel Vetter wrote: > On Fri, Oct 14, 2016 at 07:55:49PM -0400, Rob Clark wrote: >> Sometimes it is nice not to duplicate equivalent printk() and >> seq_printf() code. >> >> Signed-off-by: Rob Clark > > Ok, maybe I should wait for coffee to kick in before

[PATCH 2/6] drm: add helper for printing to log or seq_file

2016-10-14 Thread Rob Clark
Sometimes it is nice not to duplicate equivalent printk() and seq_printf() code. Signed-off-by: Rob Clark --- drivers/gpu/drm/Makefile| 3 ++- drivers/gpu/drm/drm_print.c | 54 +++ include/drm/drm_print.h | 62