Re: [PATCH 25/64] drm/vc4: dpi: Add action to disable the clock

2022-06-20 Thread Maxime Ripard
On Thu, Jun 16, 2022 at 10:47:56AM +0100, Dave Stevenson wrote: > On Thu, 16 Jun 2022 at 09:38, Maxime Ripard wrote: > > > > Hi Dave, > > > > On Tue, Jun 14, 2022 at 05:47:28PM +0100, Dave Stevenson wrote: > > > Hi Maxime. > > > > > > On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote: > > > > >

Re: [PATCH 25/64] drm/vc4: dpi: Add action to disable the clock

2022-06-16 Thread Dave Stevenson
On Thu, 16 Jun 2022 at 09:38, Maxime Ripard wrote: > > Hi Dave, > > On Tue, Jun 14, 2022 at 05:47:28PM +0100, Dave Stevenson wrote: > > Hi Maxime. > > > > On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote: > > > > > > Adding a device-managed action will make the error path easier, so let's > > >

Re: [PATCH 25/64] drm/vc4: dpi: Add action to disable the clock

2022-06-16 Thread Maxime Ripard
Hi Dave, On Tue, Jun 14, 2022 at 05:47:28PM +0100, Dave Stevenson wrote: > Hi Maxime. > > On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote: > > > > Adding a device-managed action will make the error path easier, so let's > > create one to disable our clock. > > The DPI block has two clocks

Re: [PATCH 25/64] drm/vc4: dpi: Add action to disable the clock

2022-06-14 Thread Dave Stevenson
Hi Maxime. On Fri, 10 Jun 2022 at 10:30, Maxime Ripard wrote: > > Adding a device-managed action will make the error path easier, so let's > create one to disable our clock. The DPI block has two clocks (core and pixel), and this is only affecting one of them (the core clock). (I'm actually

[PATCH 25/64] drm/vc4: dpi: Add action to disable the clock

2022-06-10 Thread Maxime Ripard
Adding a device-managed action will make the error path easier, so let's create one to disable our clock. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_dpi.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c