Re: [PATCH 28/36] fbdev: s3c2410fb: remove mach header dependency

2019-10-23 Thread Arnd Bergmann
On Wed, Oct 23, 2019 at 3:13 PM Krzysztof Kozlowski wrote: > On Thu, Oct 10, 2019 at 10:30:12PM +0200, Arnd Bergmann wrote: > > @@ -321,6 +320,7 @@ static struct s3c2410fb_mach_info jive_lcd_config = { > >* data. */ > > > > .gpcup = (0xf << 1) | (0x3f << 10), > > +

Re: [PATCH 28/36] fbdev: s3c2410fb: remove mach header dependency

2019-10-23 Thread Krzysztof Kozlowski
On Thu, Oct 10, 2019 at 10:30:12PM +0200, Arnd Bergmann wrote: > The s3c2410fb driver is too deeply intertwined with the s3c24xx > platform code. Change it in a way that avoids the use of platform > header files but having all interface data in a platform_data > header, and the private register

[PATCH 28/36] fbdev: s3c2410fb: remove mach header dependency

2019-10-10 Thread Arnd Bergmann
The s3c2410fb driver is too deeply intertwined with the s3c24xx platform code. Change it in a way that avoids the use of platform header files but having all interface data in a platform_data header, and the private register definitions next to the driver itself. One ugly bit here is that the