Re: [PATCH 3/4] drm/udl: Kill pending URBs at suspend and disconnect

2022-08-16 Thread Takashi Iwai
On Tue, 16 Aug 2022 16:01:34 +0200, Thomas Zimmermann wrote: > > Hi Takashi > > Am 16.08.22 um 15:55 schrieb Takashi Iwai: > > On Tue, 09 Aug 2022 11:19:30 +0200, > > Takashi Iwai wrote: > >> > >> On Tue, 09 Aug 2022 11:13:46 +0200, > >> Thomas Zimmermann wrote: > >>> > >>> Hi > >>> > >>> Am

Re: [PATCH 3/4] drm/udl: Kill pending URBs at suspend and disconnect

2022-08-16 Thread Thomas Zimmermann
Hi Takashi Am 16.08.22 um 15:55 schrieb Takashi Iwai: On Tue, 09 Aug 2022 11:19:30 +0200, Takashi Iwai wrote: On Tue, 09 Aug 2022 11:13:46 +0200, Thomas Zimmermann wrote: Hi Am 09.08.22 um 11:03 schrieb Takashi Iwai: On Tue, 09 Aug 2022 09:41:19 +0200, Thomas Zimmermann wrote: Hi Am

Re: [PATCH 3/4] drm/udl: Kill pending URBs at suspend and disconnect

2022-08-16 Thread Takashi Iwai
On Tue, 09 Aug 2022 11:19:30 +0200, Takashi Iwai wrote: > > On Tue, 09 Aug 2022 11:13:46 +0200, > Thomas Zimmermann wrote: > > > > Hi > > > > Am 09.08.22 um 11:03 schrieb Takashi Iwai: > > > On Tue, 09 Aug 2022 09:41:19 +0200, > > > Thomas Zimmermann wrote: > > >> > > >> Hi > > >> > > >> Am

Re: [PATCH 3/4] drm/udl: Kill pending URBs at suspend and disconnect

2022-08-09 Thread Takashi Iwai
On Tue, 09 Aug 2022 11:13:46 +0200, Thomas Zimmermann wrote: > > Hi > > Am 09.08.22 um 11:03 schrieb Takashi Iwai: > > On Tue, 09 Aug 2022 09:41:19 +0200, > > Thomas Zimmermann wrote: > >> > >> Hi > >> > >> Am 09.08.22 um 09:15 schrieb Takashi Iwai: > >>> On Tue, 09 Aug 2022 09:13:16 +0200, >

Re: [PATCH 3/4] drm/udl: Kill pending URBs at suspend and disconnect

2022-08-09 Thread Thomas Zimmermann
Hi Am 09.08.22 um 11:03 schrieb Takashi Iwai: On Tue, 09 Aug 2022 09:41:19 +0200, Thomas Zimmermann wrote: Hi Am 09.08.22 um 09:15 schrieb Takashi Iwai: On Tue, 09 Aug 2022 09:13:16 +0200, Thomas Zimmermann wrote: Hi Am 04.08.22 um 09:58 schrieb Takashi Iwai: At both suspend and

Re: [PATCH 3/4] drm/udl: Kill pending URBs at suspend and disconnect

2022-08-09 Thread Takashi Iwai
On Tue, 09 Aug 2022 09:41:19 +0200, Thomas Zimmermann wrote: > > Hi > > Am 09.08.22 um 09:15 schrieb Takashi Iwai: > > On Tue, 09 Aug 2022 09:13:16 +0200, > > Thomas Zimmermann wrote: > >> > >> Hi > >> > >> Am 04.08.22 um 09:58 schrieb Takashi Iwai: > >>> At both suspend and disconnect, we

Re: [PATCH 3/4] drm/udl: Kill pending URBs at suspend and disconnect

2022-08-09 Thread Thomas Zimmermann
Hi Am 09.08.22 um 09:15 schrieb Takashi Iwai: On Tue, 09 Aug 2022 09:13:16 +0200, Thomas Zimmermann wrote: Hi Am 04.08.22 um 09:58 schrieb Takashi Iwai: At both suspend and disconnect, we should rather cancel the pending URBs immediately. For the suspend case, the display will be turned

Re: [PATCH 3/4] drm/udl: Kill pending URBs at suspend and disconnect

2022-08-09 Thread Takashi Iwai
On Tue, 09 Aug 2022 09:13:16 +0200, Thomas Zimmermann wrote: > > Hi > > Am 04.08.22 um 09:58 schrieb Takashi Iwai: > > At both suspend and disconnect, we should rather cancel the pending > > URBs immediately. For the suspend case, the display will be turned > > off, so it makes no sense to

Re: [PATCH 3/4] drm/udl: Kill pending URBs at suspend and disconnect

2022-08-09 Thread Thomas Zimmermann
Hi Am 04.08.22 um 09:58 schrieb Takashi Iwai: At both suspend and disconnect, we should rather cancel the pending URBs immediately. For the suspend case, the display will be turned off, so it makes no sense to process the rendering. And for the disconnect case, the device may be no longer

[PATCH 3/4] drm/udl: Kill pending URBs at suspend and disconnect

2022-08-04 Thread Takashi Iwai
At both suspend and disconnect, we should rather cancel the pending URBs immediately. For the suspend case, the display will be turned off, so it makes no sense to process the rendering. And for the disconnect case, the device may be no longer accessible, hence we shouldn't do any submission.