Re: [PATCH 3/4] fbdev: imsttfb: Move a variable assignment for an error code in imsttfb_probe()

2023-05-24 Thread Markus Elfring
>> The value “-ENOMEM” was assigned to the variable “ret” >> at the beginning. >> Move this statement directly before the first ioremap() call. > > Please do not move such variables without real need. Is there a need to explain desirable effects better? > It makes backporting (of this and maybe

Re: [PATCH 3/4] fbdev: imsttfb: Move a variable assignment for an error code in imsttfb_probe()

2023-05-24 Thread Helge Deller
On 5/23/23 19:42, Markus Elfring wrote: From: Markus Elfring Date: Tue, 23 May 2023 18:30:26 +0200 The value “-ENOMEM” was assigned to the variable “ret” at the beginning. Move this statement directly before the first ioremap() call. Please do not move such variables without real need. It mak

[PATCH 3/4] fbdev: imsttfb: Move a variable assignment for an error code in imsttfb_probe()

2023-05-23 Thread Markus Elfring
From: Markus Elfring Date: Tue, 23 May 2023 18:30:26 +0200 The value “-ENOMEM” was assigned to the variable “ret” at the beginning. Move this statement directly before the first ioremap() call. Signed-off-by: Markus Elfring --- drivers/video/fbdev/imsttfb.c | 2 +- 1 file changed, 1 insertion(