Re: [EXT] Re: [PATCH 3/5] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-16 Thread Olivier Masse
Hi Nicolas, Thanks for your comment, indeed these PR is linked to OPTEE OS. This one is using the same bindings to define the Secure Data Path reserved memory: https://github.com/OP-TEE/optee_os/commit/eb108a04369fbfaf60c03c0e00bbe9489a761c69 However, I'm not aware of another shared heap that

Re: [PATCH 3/5] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-16 Thread Nicolas Dufresne
Hi, Le mardi 02 août 2022 à 11:58 +0200, Olivier Masse a écrit : > add Linaro secure heap bindings: linaro,secure-heap Just a curiosity, how is this specific to Linaro OPTEE OS ? Shouldn't it be "de- linaro-ified" somehow ? regards, Nicolas > use genalloc to allocate/free buffer from buffer

Re: [EXT] Re: [PATCH 3/5] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-05 Thread Olivier Masse
Hi Brian, Sorry for pushing all the patches again, but I've done some cleanup regarding your comments. secure-heap are now protected by default and no mapping could be done for the CPU. deferred-free is no more needed. useless page pool code removed too. Best regards, Olivier On mer.,

Re: [EXT] Re: [PATCH 3/5] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-03 Thread Olivier Masse
Hi Brian, Thanks for your comments, please find my reply below. On mar., 2022-08-02 at 15:39 +0100, Brian Starkey wrote: > Caution: EXT Email > > Hi Olivier, > > Some comments below as I mentioned off-list. > > One additional point: some devices need to know if a buffer is > protected, so

Re: [EXT] Re: [PATCH 3/5] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-03 Thread Brian Starkey
Hi, On Wed, Aug 03, 2022 at 11:07:54AM +, Olivier Masse wrote: > Hi Brian, > > Thanks for your comments, please find my reply below. > > On mar., 2022-08-02 at 15:39 +0100, Brian Starkey wrote: > > Caution: EXT Email > > > > Hi Olivier, > > > > Some comments below as I mentioned off-list.

[PATCH 3/5] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-03 Thread Olivier Masse
add Linaro secure heap bindings: linaro,secure-heap use genalloc to allocate/free buffer from buffer pool. buffer pool info is from dts. use sg_table instore the allocated memory info, the length of sg_table is 1. implement secure_heap_buf_ops to implement buffer share in difference device: 1.

Re: [PATCH 3/5] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-02 Thread Brian Starkey
Hi Olivier, Some comments below as I mentioned off-list. One additional point: some devices need to know if a buffer is protected, so that they can configure registers appropriately to make use of that protected buffer. There was previously a discussion about adding a flag to a dma_buf to