[Intel-gfx] [PATCH 3/5] drm/i915: add SNB and IVB video sprite support

2011-11-08 Thread Daniel Vetter
On Tue, Nov 08, 2011 at 02:31:00PM -0800, Jesse Barnes wrote: > On Tue, 8 Nov 2011 22:57:03 +0100 Daniel Vetter wrote: > > > @@ -270,8 +270,14 @@ void intel_fb_restore_mode(struct drm_device *dev) > > > { > > > int ret; > > > drm_i915_private_t *dev_priv = dev->dev_private; > > > + struct drm

[Intel-gfx] [PATCH 3/5] drm/i915: add SNB and IVB video sprite support

2011-11-08 Thread Daniel Vetter
On Tue, Nov 08, 2011 at 10:57:03PM +0100, Daniel Vetter wrote: > > + /* > > +* Clamp the width & height into the visible area. Note we don't > > +* try to scale the source if part of the visible region is offscreen. > > +* The caller must handle that by adjusting source offset and si

[Intel-gfx] [PATCH 3/5] drm/i915: add SNB and IVB video sprite support

2011-11-08 Thread Daniel Vetter
On Mon, Nov 07, 2011 at 10:02:54AM -0800, Jesse Barnes wrote: > The video sprites support various video surface formats natively and can > handle scaling as well. So add support for them using the new DRM core > sprite support functions. > > Signed-off-by: Jesse Barnes I've not checked the wate

Re: [Intel-gfx] [PATCH 3/5] drm/i915: add SNB and IVB video sprite support

2011-11-08 Thread Daniel Vetter
On Tue, Nov 08, 2011 at 02:31:00PM -0800, Jesse Barnes wrote: > On Tue, 8 Nov 2011 22:57:03 +0100 Daniel Vetter wrote: > > > @@ -270,8 +270,14 @@ void intel_fb_restore_mode(struct drm_device *dev) > > > { > > > int ret; > > > drm_i915_private_t *dev_priv = dev->dev_private; > > > + struct drm

Re: [Intel-gfx] [PATCH 3/5] drm/i915: add SNB and IVB video sprite support

2011-11-08 Thread Jesse Barnes
On Tue, 8 Nov 2011 22:57:03 +0100 Daniel Vetter wrote: > I've not checked the watermarks, that kind of magic eludes me ;-) A few > other comments below. I need to get docs on that; in particular WM handling with downscaling is an unknown. > > +#define DVS_SCALE_ENABLE (1<<31) > > +#define DV

[Intel-gfx] [PATCH 3/5] drm/i915: add SNB and IVB video sprite support

2011-11-08 Thread Jesse Barnes
On Tue, 8 Nov 2011 22:57:03 +0100 Daniel Vetter wrote: > I've not checked the watermarks, that kind of magic eludes me ;-) A few > other comments below. I need to get docs on that; in particular WM handling with downscaling is an unknown. > > +#define DVS_SCALE_ENABLE (1<<31) > > +#define DV

Re: [Intel-gfx] [PATCH 3/5] drm/i915: add SNB and IVB video sprite support

2011-11-08 Thread Daniel Vetter
On Tue, Nov 08, 2011 at 10:57:03PM +0100, Daniel Vetter wrote: > > + /* > > +* Clamp the width & height into the visible area. Note we don't > > +* try to scale the source if part of the visible region is offscreen. > > +* The caller must handle that by adjusting source offset and si

Re: [Intel-gfx] [PATCH 3/5] drm/i915: add SNB and IVB video sprite support

2011-11-08 Thread Daniel Vetter
On Mon, Nov 07, 2011 at 10:02:54AM -0800, Jesse Barnes wrote: > The video sprites support various video surface formats natively and can > handle scaling as well. So add support for them using the new DRM core > sprite support functions. > > Signed-off-by: Jesse Barnes I've not checked the wate

[PATCH 3/5] drm/i915: add SNB and IVB video sprite support

2011-11-07 Thread Jesse Barnes
The video sprites support various video surface formats natively and can handle scaling as well. So add support for them using the new DRM core sprite support functions. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/Makefile|1 + drivers/gpu/drm/i915/i915_reg.h | 123 ++

[PATCH 3/5] drm/i915: add SNB and IVB video sprite support

2011-11-07 Thread Jesse Barnes
The video sprites support various video surface formats natively and can handle scaling as well. So add support for them using the new DRM core sprite support functions. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/Makefile|1 + drivers/gpu/drm/i915/i915_reg.h | 123 ++