[PATCH 33/39] drm: rip out drm_core_has_MTRR checks

2013-07-10 Thread Daniel Vetter
On Wed, Jul 10, 2013 at 6:27 PM, Andy Lutomirski wrote: > Are all of those codepaths really inaccessible in non-legacy drm > drivers? I didn't try to fully unravel all the ioctls and such, but > it seems like userspace could add bufs and map them. Since the mtrr > code isn't very robust

[PATCH 33/39] drm: rip out drm_core_has_MTRR checks

2013-07-10 Thread Daniel Vetter
On Wed, Jul 10, 2013 at 5:41 PM, David Herrmann wrote: > On Wed, Jul 10, 2013 at 5:22 PM, Daniel Vetter > wrote: >> On Wed, Jul 10, 2013 at 3:51 PM, David Herrmann >> wrote: -#if __OS_HAS_MTRR -static inline int drm_core_has_MTRR(struct drm_device *dev) -{ - return

[PATCH 33/39] drm: rip out drm_core_has_MTRR checks

2013-07-10 Thread David Herrmann
Hi On Wed, Jul 10, 2013 at 5:22 PM, Daniel Vetter wrote: > On Wed, Jul 10, 2013 at 3:51 PM, David Herrmann > wrote: >>> -#if __OS_HAS_MTRR >>> -static inline int drm_core_has_MTRR(struct drm_device *dev) >>> -{ >>> - return drm_core_check_feature(dev, DRIVER_USE_MTRR); >>> -} >>> -#else

[PATCH 33/39] drm: rip out drm_core_has_MTRR checks

2013-07-10 Thread Daniel Vetter
On Wed, Jul 10, 2013 at 3:51 PM, David Herrmann wrote: >> -#if __OS_HAS_MTRR >> -static inline int drm_core_has_MTRR(struct drm_device *dev) >> -{ >> - return drm_core_check_feature(dev, DRIVER_USE_MTRR); >> -} >> -#else >> -#define drm_core_has_MTRR(dev) (0) >> -#endif >> - > > That was

[PATCH 33/39] drm: rip out drm_core_has_MTRR checks

2013-07-10 Thread David Herrmann
Hi On Wed, Jul 10, 2013 at 2:12 PM, Daniel Vetter wrote: > The new arch_phys_wc_add/del functions do the right thing both with > and without MTRR support in the kernel. So we can drop these > additional checks. > > Cc: Andy Lutomirski > Signed-off-by: Daniel Vetter > --- >

[PATCH 33/39] drm: rip out drm_core_has_MTRR checks

2013-07-10 Thread Daniel Vetter
The new arch_phys_wc_add/del functions do the right thing both with and without MTRR support in the kernel. So we can drop these additional checks. Cc: Andy Lutomirski Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_bufs.c | 13 + drivers/gpu/drm/drm_pci.c | 11 +--

[PATCH 33/39] drm: rip out drm_core_has_MTRR checks

2013-07-10 Thread Andy Lutomirski
On Wed, Jul 10, 2013 at 8:59 AM, Daniel Vetter wrote: > On Wed, Jul 10, 2013 at 5:41 PM, David Herrmann > wrote: >> On Wed, Jul 10, 2013 at 5:22 PM, Daniel Vetter >> wrote: >>> On Wed, Jul 10, 2013 at 3:51 PM, David Herrmann >>> wrote: > -#if __OS_HAS_MTRR > -static inline int

[PATCH 33/39] drm: rip out drm_core_has_MTRR checks

2013-07-10 Thread Daniel Vetter
The new arch_phys_wc_add/del functions do the right thing both with and without MTRR support in the kernel. So we can drop these additional checks. Cc: Andy Lutomirski l...@amacapital.net Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_bufs.c | 13 +

Re: [PATCH 33/39] drm: rip out drm_core_has_MTRR checks

2013-07-10 Thread David Herrmann
Hi On Wed, Jul 10, 2013 at 2:12 PM, Daniel Vetter daniel.vet...@ffwll.ch wrote: The new arch_phys_wc_add/del functions do the right thing both with and without MTRR support in the kernel. So we can drop these additional checks. Cc: Andy Lutomirski l...@amacapital.net Signed-off-by: Daniel

Re: [PATCH 33/39] drm: rip out drm_core_has_MTRR checks

2013-07-10 Thread Daniel Vetter
On Wed, Jul 10, 2013 at 3:51 PM, David Herrmann dh.herrm...@gmail.com wrote: -#if __OS_HAS_MTRR -static inline int drm_core_has_MTRR(struct drm_device *dev) -{ - return drm_core_check_feature(dev, DRIVER_USE_MTRR); -} -#else -#define drm_core_has_MTRR(dev) (0) -#endif - That was

Re: [PATCH 33/39] drm: rip out drm_core_has_MTRR checks

2013-07-10 Thread David Herrmann
Hi On Wed, Jul 10, 2013 at 5:22 PM, Daniel Vetter daniel.vet...@ffwll.ch wrote: On Wed, Jul 10, 2013 at 3:51 PM, David Herrmann dh.herrm...@gmail.com wrote: -#if __OS_HAS_MTRR -static inline int drm_core_has_MTRR(struct drm_device *dev) -{ - return drm_core_check_feature(dev,

Re: [PATCH 33/39] drm: rip out drm_core_has_MTRR checks

2013-07-10 Thread Daniel Vetter
On Wed, Jul 10, 2013 at 5:41 PM, David Herrmann dh.herrm...@gmail.com wrote: On Wed, Jul 10, 2013 at 5:22 PM, Daniel Vetter daniel.vet...@ffwll.ch wrote: On Wed, Jul 10, 2013 at 3:51 PM, David Herrmann dh.herrm...@gmail.com wrote: -#if __OS_HAS_MTRR -static inline int

Re: [PATCH 33/39] drm: rip out drm_core_has_MTRR checks

2013-07-10 Thread Daniel Vetter
On Wed, Jul 10, 2013 at 6:27 PM, Andy Lutomirski l...@amacapital.net wrote: Are all of those codepaths really inaccessible in non-legacy drm drivers? I didn't try to fully unravel all the ioctls and such, but it seems like userspace could add bufs and map them. Since the mtrr code isn't very

Re: [PATCH 33/39] drm: rip out drm_core_has_MTRR checks

2013-07-10 Thread Andy Lutomirski
On Wed, Jul 10, 2013 at 8:59 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: On Wed, Jul 10, 2013 at 5:41 PM, David Herrmann dh.herrm...@gmail.com wrote: On Wed, Jul 10, 2013 at 5:22 PM, Daniel Vetter daniel.vet...@ffwll.ch wrote: On Wed, Jul 10, 2013 at 3:51 PM, David Herrmann