Re: [PATCH 4/5] drm/panfrost: add amlogic reset quirk callback

2020-09-09 Thread Neil Armstrong
Hi, On 09/09/2020 14:23, Steven Price wrote: > On 08/09/2020 16:18, Neil Armstrong wrote: >> The T820, G31 & G52 GPUs integratewd by Amlogic in the respective GXM, >> G12A/SM1 & G12B >> SoCs needs a quirk in the PWR registers at the GPU reset time. >> >> Since the documentation of the GPU cores ar

Re: [PATCH 4/5] drm/panfrost: add amlogic reset quirk callback

2020-09-09 Thread Steven Price
On 08/09/2020 16:18, Neil Armstrong wrote: The T820, G31 & G52 GPUs integratewd by Amlogic in the respective GXM, G12A/SM1 & G12B SoCs needs a quirk in the PWR registers at the GPU reset time. Since the documentation of the GPU cores are not public, we do not know what does these values, but t

Re: [PATCH 4/5] drm/panfrost: add amlogic reset quirk callback

2020-09-09 Thread Alyssa Rosenzweig
> Since the documentation of the GPU cores are not public, we do not know what > does these > values, but they permit having a fully functional GPU running with Panfrost. Since this is Amlogic magic, not specifically GPU, I'd rephrase this as "Since the Amlogic's integration of the GPU cores with

Re: [PATCH 4/5] drm/panfrost: add amlogic reset quirk callback

2020-09-08 Thread kernel test robot
Hi Neil, I love your patch! Perhaps something to improve: [auto build test WARNING on iommu/next] [also build test WARNING on soc/for-next linus/master v5.9-rc4 next-20200908] [cannot apply to xlnx/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

[PATCH 4/5] drm/panfrost: add amlogic reset quirk callback

2020-09-08 Thread Neil Armstrong
The T820, G31 & G52 GPUs integratewd by Amlogic in the respective GXM, G12A/SM1 & G12B SoCs needs a quirk in the PWR registers at the GPU reset time. Since the documentation of the GPU cores are not public, we do not know what does these values, but they permit having a fully functional GPU runn