Re: [PATCH 4/5] drm: convert drivers to use drm_of_find_panel_or_bridge

2017-02-08 Thread Maxime Ripard
Hi Rob, On Mon, Feb 06, 2017 at 11:32:01AM -0600, Rob Herring wrote: > On Mon, Feb 06, 2017 at 11:03:01AM +0100, Maxime Ripard wrote: > > Hi Rob, > > > > On Fri, Feb 03, 2017 at 09:36:34PM -0600, Rob Herring wrote: > > > Similar to the previous commit, convert drivers open coding OF graph > > >

Re: [PATCH 4/5] drm: convert drivers to use drm_of_find_panel_or_bridge

2017-02-06 Thread Philipp Zabel
On Fri, 2017-02-03 at 21:36 -0600, Rob Herring wrote: > Similar to the previous commit, convert drivers open coding OF graph > parsing to use drm_of_find_panel_or_bridge instead. > > This changes some error messages to debug messages (in the graph core). > Graph connections are often "no

Re: [PATCH 4/5] drm: convert drivers to use drm_of_find_panel_or_bridge

2017-02-06 Thread Maxime Ripard
Hi Rob, On Fri, Feb 03, 2017 at 09:36:34PM -0600, Rob Herring wrote: > Similar to the previous commit, convert drivers open coding OF graph > parsing to use drm_of_find_panel_or_bridge instead. > > This changes some error messages to debug messages (in the graph core). > Graph connections are

Re: [PATCH 4/5] drm: convert drivers to use drm_of_find_panel_or_bridge

2017-02-06 Thread Fabio Estevam
On Sun, Feb 5, 2017 at 10:01 PM, Fabio Estevam wrote: > > The tda998x_probe() returns success, but tda998x_bind() is never called. > > I am trying to understand what needs to be done in > drivers/gpu/drm/mxsfb/ so that it can bind the tda998x driver. Looks like that

Re: [PATCH 4/5] drm: convert drivers to use drm_of_find_panel_or_bridge

2017-02-06 Thread Rob Herring
On Mon, Feb 06, 2017 at 11:03:01AM +0100, Maxime Ripard wrote: > Hi Rob, > > On Fri, Feb 03, 2017 at 09:36:34PM -0600, Rob Herring wrote: > > Similar to the previous commit, convert drivers open coding OF graph > > parsing to use drm_of_find_panel_or_bridge instead. > > > > This changes some

Re: [PATCH 4/5] drm: convert drivers to use drm_of_find_panel_or_bridge

2017-02-05 Thread Fabio Estevam
Hi Rob, On Sat, Feb 4, 2017 at 1:36 AM, Rob Herring wrote: > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_out.c > b/drivers/gpu/drm/mxsfb/mxsfb_out.c > index fa8d17399407..f7d729aa09bd 100644 > --- a/drivers/gpu/drm/mxsfb/mxsfb_out.c > +++ b/drivers/gpu/drm/mxsfb/mxsfb_out.c > @@

[PATCH 4/5] drm: convert drivers to use drm_of_find_panel_or_bridge

2017-02-05 Thread Rob Herring
Similar to the previous commit, convert drivers open coding OF graph parsing to use drm_of_find_panel_or_bridge instead. This changes some error messages to debug messages (in the graph core). Graph connections are often "no connects" depending on the particular board, so we want to avoid

Re: [PATCH 4/5] drm: convert drivers to use drm_of_find_panel_or_bridge

2017-02-05 Thread Rob Herring
On Sat, Feb 4, 2017 at 2:26 PM, Fabio Estevam wrote: > Hi Rob, > > On Sat, Feb 4, 2017 at 1:36 AM, Rob Herring wrote: > >> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_out.c >> b/drivers/gpu/drm/mxsfb/mxsfb_out.c >> index fa8d17399407..f7d729aa09bd 100644 >> ---

Re: [PATCH 4/5] drm: convert drivers to use drm_of_find_panel_or_bridge

2017-02-05 Thread Fabio Estevam
On Sun, Feb 5, 2017 at 8:25 PM, Rob Herring wrote: > Did the bridge driver probe? This function just checks lists of > registered panels and bridges. The tda998x_probe() returns success, but tda998x_bind() is never called. I am trying to understand what needs to be done in